Git Product home page Git Product logo

Comments (3)

jackc avatar jackc commented on August 27, 2024

This package is only receiving bug fixes. In pgx v5 the pgtype library is part of the main repo. But regardless, timestamp with time zone is unlikely to be supported. See jackc/pgx#1940 for previous discussion.

from pgtype.

vnicolici avatar vnicolici commented on August 27, 2024

All right, no problem, after reading a few related bugs and the PostgreSQL documentation it's clear the use of this data type is not recommended, and there are good reasons for that. So it's actually a good thing I had to switch to "time without time zone", and I'm fine with this data type not being supported.

In fact I remember reading about this data type not being recommended a few years ago. But when working on a new feature recently, I missed that part in the PostgreSQL documentation, even though I was specifically looking for that language discouraging its use, so I assumed it is OK to use it. In retrospect, after reading more about how that data type works, it was clearly NOT OK. Daylight savings would have caused a huge mess if I kept using it.

However, I think that the documentation for pgtype.Time should make it clear that the "time with time zone" datatype is not not supported, and that its usage is not recommended by PostgreSQL. Even the pgx v5 documentation doesn't mention that.

from pgtype.

jackc avatar jackc commented on August 27, 2024

However, I think that the documentation for pgtype.Time should make it clear that the "time with time zone" datatype is not not supported, and that its usage is not recommended by PostgreSQL. Even the pgx v5 documentation doesn't mention that.

Fair enough.

jackc/pgx@a68e14f

from pgtype.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.