Comments (9)
I'd love to take this one on if possible? Will probably take me a day or two though.
from watch-github-labels.
@jacquesdev sure thing, that would be great!
from watch-github-labels.
I would love to help out as well!
from watch-github-labels.
@tmarkovic - that sounds great to me as well. If it's ok with you - I just want to setup mocha and maybe one test so that it's in place, then you can continue with the rest of the tests, and I can fill any gaps going forward. I just wanted an opportunity to do a mocha implementation from scratch.
from watch-github-labels.
@jacquesdev Just my thought, there's no reason why we can't split the writing of tests as long as a runner and framework is in place! Have you given Jest any thought though?
Looking forward to this either way 👍
from watch-github-labels.
Awesome - thanks @tmarkovic @jacquesdev!
from watch-github-labels.
I've started writing a test for the notify function, though I must admit that I'm not very experienced with testing at all so it might take me some time.
My current approach is to use Nock to mock the HTTP-call. Does it make sense to use a stub for parseIssue? I feel like it would be nice to not couple the test to github specific data but I may very well be wrong here.
Any recommendations on how I should go about constructing the IFFT url before the test?
from watch-github-labels.
Hi @tmarkovic, sorry for the delayed response.
That's a good idea - if you stubparseIssue
to return an object with { owner, repo, title, url, labels }
, we'll avoid re-testing that function.
If you also declare process.env.MAKER_KEY
in the test, we can just make sure we send a GET request to the correct URL. We'll know what the URL is, based on the data we get from parseIssue
(which we're stubbing anyway) 🙂
from watch-github-labels.
Hi @jacquesdev @tmarkovic - sorry I haven't followed up sooner on this.
Did either of you get the chance to continue working on this? If so, it would be great to see how it's going 🙂 Happy to lend a hand if you've run into any problems.
from watch-github-labels.
Related Issues (1)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from watch-github-labels.