Symbolic links in nested repositories change after running gitman install about gitman HOT 9 CLOSED

I'm not aware of a change that would cause that. What version are you using? Can you pinpoint which version introduced the new behavior?

from gitman.

I'm using version 3.3.2, which seems to be the version that introduced it. When I downgrade to 3.3.1, it doesn't happen. I guess it probably changed with pull request #295

from gitman.

@DavidWatkins do you think your PR could have unintentionally changed this behavior?

from gitman.

My changes caused this change, but this is because of how find_nested_configs works. To fix this we'd have to change the way find_nested_configs works to instead install nested configs in isolation rather than building up a global config for the top level repository. To get the old functionality you could use --depth 2 when installing in the meantime.

from gitman.

@pritzvac Do you have an example config I can look at? I am trying to see where it would incorrectly symlink but L400 of gitman/models/config.py uses the current subdirectory as the root and shouldn't be symlinking from the parent directory.

from gitman.

Sure, thanks for looking into it. Here's a quick example config I made, linking to subrepository with this config: https://github.com/ctu-mrs/octomap_mapping_planning/blob/master/.gitman.yml

location: .gitman
sources:
  - repo: https://github.com/ctu-mrs/octomap_mapping_planning.git
    name: octomap_mapping_planning
    rev: master
    type: git
    params:
    sparse_paths:
      -
    links:
      - source: ''
        target: ros_packages/octomap_mapping_planning
groups:
  -
default_group: ''

It actually works fine when I call gitman install for the first time, but then it changes the symlinks in the subrepository, when I call it for a second time.

from gitman.

@pritzvac Can you try my fix in PR #300 and see if it resolves your issue?

from gitman.

Yes, the PR fixed my issue, thanks.

from gitman.

Here's the updated release: https://pypi.org/project/gitman/3.3.3/

from gitman.