Git Product home page Git Product logo

Comments (7)

thnurg avatar thnurg commented on May 20, 2024 1

I just had a thought regarding daylight savings. Those of use who practice that needless software overhead every year will probably have had the change over the last few weeks, so I pulled a report for March 22nd. (We switched from GMT to BST on March 24th.) The report showed the time in GMT. If I generate one for today then it will show BST. Go is obviously handling the server's timezone correctly. I wondered if daylight savings might cause issues generating reports that occurred before the most recent change but am happy to report that's not the case.

from reporter.

IzakMarais avatar IzakMarais commented on May 20, 2024

Great work with your reporter.

Thanks! Glad you found it useful. Always interested in hearing who is using it and where, if you don't mind sharing.

This is hard coded currently.

Would you typically like to set this per dashboard as a query parameter, or would per reporter instance as a command line flag be sufficient?

from reporter.

kesnol avatar kesnol commented on May 20, 2024

Any of the options you propose is fine for me, maybe using a variable is more flexible.
As the developer you decide which one you like the most or the one that is easiest to implement.

Thanks!

from reporter.

thnurg avatar thnurg commented on May 20, 2024

Hi Izak,
Thanks for this superb software. I suggest that the reporter get the server's local time zone, if possible, and use that as the default. The user could then override that with a query parameter.

from reporter.

thnurg avatar thnurg commented on May 20, 2024

I had a wee play with the code. Simply removing the UTC(). from the time formatting lines produces a report that displays time as the server's local time. I think this should be the default behaviour since most people want to read reports that display their local time.
If you want to get fancy later on and add a time zone parameter then that would be awesome, but for now I think displaying local time is a better default behaviour than UTC.

Thanks again.

from reporter.

IzakMarais avatar IzakMarais commented on May 20, 2024

@thnurg Thanks for the suggestion, sounds easy enough. So if the server is in UTC the behaviour stays unchanged. I will implement this when I have time, sounds like a quick and easy change.

from reporter.

IzakMarais avatar IzakMarais commented on May 20, 2024

Thanks for the test.

from reporter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.