Comments (8)
Not the greatest workaround, but I didn't have time to look for a better working solution at the moment. I personally left in the original for backwards compatibility. Regardless, it does look like rows are being fazed out.
type dashContainer struct {
Dashboard Dashboard // This seemed to make more sense to me.
Meta struct {
Slug string
}
}
func (dc dashContainer) NewDashboard(variables url.Values) Dashboard {
var dash Dashboard
dash.Title = sanitizeLaTexInput(dc.Dashboard.Title)
dash.Description = sanitizeLaTexInput(dc.Dashboard.Description)
dash.VariableValues = sanitizeLaTexInput(getVariablesValues(variables))
if len(dc.Dashboard.Rows) == 0 {
for _, p := range dc.Dashboard.Panels {
p.Title = sanitizeLaTexInput(p.Title)
dash.Panels = append(dash.Panels, p)
}
return dash
}
for _, row := range dc.Dashboard.Rows {
row.Title = sanitizeLaTexInput(row.Title)
dash.Rows = append(dash.Rows, row)
for _, p := range dc.Dashboard.Panels {
p.Title = sanitizeLaTexInput(p.Title)
dash.Panels = append(dash.Panels, p)
}
}
return dash
}
from reporter.
Nope, sorry. I have not checked yet.
A PR would be welcome. I wonder what would be the best approach to handle such a breaking change? One could release a new version that only works with 5.0 and have the old version work with pre 5.0 grafana. Or it could support both via a grafana-version flag...
from reporter.
Does not work fully. The PNGs seem to be downloaded, but are not displayed in the generated PDF.
from reporter.
I just downloaded grafana 5.0 and tested against the latest master of grafana-reporter. Everything seems to work fine. Closing this issue until I get some concrete examples to the opposite.
from reporter.
Hmm from the docs I see:
New uid-based routes in the dashboard API have been introduced to retrieve and delete dashboards. The corresponding slug-based routes have been deprecated and will be removed in a future release.
Will see if I can support the new API, to avoid nasty surprises in a future release when the deprectation happens.
from reporter.
Regardless, it does look like rows are being fazed out.
Yes and this type of solution for supporting both seems to be required, since old imported dashboards still return rows when fetched via the new API Grafana 5.
from reporter.
Dashboard Dashboard // This seemed to make more sense to me.
I missed this bug (was introduced in a recent PR). Luckily it seems harmless. Fixed it now while making the other changes.
from reporter.
The v2.0.0 release addresses this issue.
https://github.com/IzakMarais/reporter/releases/tag/v2.0.0
from reporter.
Related Issues (20)
- The API try to send an email to 'postmaster@grafana' every time is called HOT 3
- How to change images size that are rendered using '-grid-layout'? HOT 1
- Timeout Error HOT 8
- How to set the size of imported pdf HOT 2
- Openshift Grafana route addr update instead of Grafana IP and port into Grafana reporter. HOT 3
- Grafana device or resource busy HOT 1
- Time span Required (and only used) in command line mode. (default "from=now-3h&to=now")
- Does this support repeat variable? HOT 1
- pdfTeX error HOT 1
- ERROR rendering PNGs in parralel for dash HOT 7
- Reporter Not Working HOT 1
- How to custom textTemplate.go
- Error generating report: error fetching dashboard xxx HOT 1
- Reporting breaks with HTTPS Grafana server HOT 1
- Error on get panel Info "Unexpected error" HOT 1
- Adding grid layout to Link in Grafana Dashboard settings HOT 2
- How to manipulate variables ? HOT 5
- dial tcp 127.0.0.1:3000: connect: connection refused HOT 5
- Generate horizontal pdf HOT 1
- Collapsed rows omitted from report generation - expected behavior? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reporter.