Git Product home page Git Product logo

Comments (4)

alice-i-cecile avatar alice-i-cecile commented on August 16, 2024 1

Oh super interesting; so then we can have different flavors of commands and flush them separately?

IMO this is probably best tackled with a PR to Bevy itself; I think that this should be able to be assessed and implemented independently of the rest of the stageless work.

from iyes_loopless.

zicklag avatar zicklag commented on August 16, 2024 1

Oh super interesting; so then we can have different flavors of commands and flush them separately?

Yep! I think with an unsafe implementation of SystemParam we can even get ergonomics matching Bevy's built-in Commands struct so that you don't have to do let commands = my_commands.commands(). I've got to try that out.

IMO this is probably best tackled with a PR to Bevy itself; I think that this should be able to be assessed and implemented independently of the rest of the stageless work.

Makes sense. I'll close this then and move to Bevy.

from iyes_loopless.

zicklag avatar zicklag commented on August 16, 2024 1

While writing an example for how to use this I found that apparently Bevy already flushes the command queues in between stages, by default, unless you explicitly add a stage that doesn't flush the buffers, so this isn't actually necessary, I don't think.

Since we aren't allowed to insert the exclusive system that flushes the commands anywhere except in it's own stage or at the beginning or end of an existing stage, it doesn't hold any advantage over just letting Bevy do it's default command flushing between stages.

I thought Bevy only flushed the commands at the end of the frame, so I was solving for a non issue. :)

from iyes_loopless.

zicklag avatar zicklag commented on August 16, 2024

@alice-i-cecile pinging you because you helped start the stageless RFC and might have thoughts on this implementation.

from iyes_loopless.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.