Git Product home page Git Product logo

Comments (3)

metincansiper avatar metincansiper commented on May 18, 2024

@maxkfranz we have not documented them because the users are already able to customize the context menu itself and the menu items using menuItemClasses and contextMenuClasses options. Each context menu (one per each cytoscape.js instance where this extension is registered) has classes specified by contextMenuClasses along with cy-context-menus-cxt-menu. Each context menu item has classes specified by menuItemClasses along with cy-context-menus-cxt-menuitem.

One downside of specifying that classes may be that, if we specify them in README then modifying them will become an API change and we will need to make a major release when we need to modify them. As we already provide customization for this, I think that we can keep avoiding documenting these classes. What do you thinkl about this? Do you think which way is more preferable to go?

Also, I realized that in README we did not mention that the users should include that css file while using this extension. I think that specifing it would be nice.

from cytoscape.js-context-menus.

maxkfranz avatar maxkfranz commented on May 18, 2024

OK.

If the user is expected to include the default stylesheet, then we should probably point the style field of package.json to the css file so it's more automatic.

from cytoscape.js-context-menus.

metincansiper avatar metincansiper commented on May 18, 2024

@maxkfranz I added that field to package.json. Would you close the issue if there is no problem?

from cytoscape.js-context-menus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.