Git Product home page Git Product logo

Comments (3)

huan avatar huan commented on May 18, 2024

Yes, I also have this issue.

After looking the code, it seems the following code gameOverOffset is not right anymore:

// Read Game state
// (If game is ended or is playing)
GameManipulator.readGameState = function () {
  // Read GameOver
  var found = Scanner.scanUntil(
    [
      GameManipulator.offset[0] + GameManipulator.gameOverOffset[0],
      GameManipulator.offset[1] + GameManipulator.gameOverOffset[1]
    ],

    [2, 0], COLOR_DINOSAUR, false, 20
  );

I guess it's because the position of the GAME OVER is changed in the new version of Chrome?

My system is:

  • Ubuntu 17.04
  • Chrome 59.0.3071.86 (Official Build) (64-bit)

from iamdinosaur.

huan avatar huan commented on May 18, 2024

@GritPixel I changed

--- a/GameManipulator.js
+++ b/GameManipulator.js
@@ -28,8 +28,9 @@ var GameManipulator = {
   gamestate: 'OVER',
 
   // GameOver Position
-  gameOverOffset: [190, -82],
+  gameOverOffset: [190, -75], 

The above change fixes this issue for me.

Will send a PR later to make it compatible with different Chrome Browsers.

from iamdinosaur.

himahuja avatar himahuja commented on May 18, 2024

Sir, I had to change back the coordinates to [190, -82] for it to work for me. I am on a mac, and maybe this is system dependent. Great job with this though.

from iamdinosaur.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.