Git Product home page Git Product logo

Comments (2)

vladev avatar vladev commented on June 15, 2024

I've stumbled upon this as well.

// en/component/index.ts
totalPrice: '{value:Currency|currency}',
// custom-types.ts
export type Currency = { value: number; currency: string }
// formatters.ts
currency: (value: Currency) =>
  number(locale, {
    style: 'currency',
    currency: value.currency,
    maximumFractionDigits: 2,
  })(value.value)

from typesafe-i18n.

jamespamplin avatar jamespamplin commented on June 15, 2024

I also got hit with this - and also with a currency formatter similar to @vladev.

// i18n/custom-types.ts
export type MonetaryAmount = {
  currency: string
  value: number
}

// i18n/en/index.ts
const en = {
  money: "{0:MonetaryAmount|currency}",
}

// i18n/formatters.ts
const formatters: Formatters = {
  currency: ({ value, currency }: MonetaryAmount): string => {
    const formatter = new Intl.NumberFormat(locale, {
    style: "currency",
    currency,
    minimumFractionDigits: 0,
  }

  return formatter.format(value)
}

// component.ts
function Money({value, valueCurrency}: {value: number, valueCurrency: string}) {
  const { LL } = useI18nContext()
  // below is correctly typed, but throws TypeError: Cannot read property 'value' of undefined
  return <Text>{LL.money({ value, currency: valueCurrency })}</Text>
}

Even though this was passing typescript, the call to LL was passing the argument as a "keyed argument". Passing the index through in an object works around the issue, but fails typescript: LL.money({ 0: { value, currency: valueCurrency }})

As a workaround, specifying an argument key in the translation passes typescript and works as expected at runtime:

// i18n/en/index.ts
const en = {
  money: "{money:MonetaryAmount|currency}",
}

// component.ts
function Money({value, valueCurrency}: {value: number, valueCurrency: string}) {
  const { LL } = useI18nContext()
  // now compiles in typescript and works as expected at runtime
  return <Text>{LL.money({ money: { value, currency: valueCurrency }})}</Text>
}

So this is only an issue if you use a single indexed argument in the translation.

from typesafe-i18n.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.