Git Product home page Git Product logo

Comments (5)

itmayziii avatar itmayziii commented on June 15, 2024

@marvinrabe

Thank you for the issue @marvinrabe, could you please share your gatsby-config.js file so I can better understand how this would happen?

from gatsby-plugin-no-javascript.

itmayziii avatar itmayziii commented on June 15, 2024

Going to leave this issue open a bit longer but I have not been able to reproduce this myself. Unless @marvinrabe can provide a reproduction of the issue soon then I will have to close this.

from gatsby-plugin-no-javascript.

marvinrabe avatar marvinrabe commented on June 15, 2024

This happens when using a gatsby source plugin for fetching remote data.

This can be seen with: https://github.com/TryGhost/gatsby-starter-ghost

from gatsby-plugin-no-javascript.

mathiasha avatar mathiasha commented on June 15, 2024

This is also an issue for me.

What i originally did (before I found this plugin) was i created a gatsby-ssr.js like this:

const get = require('lodash/get');

function filterJavascriptItems(item) {
  const href = get(item, 'props.href');
  const src = get(item, 'props.src');
  const expression = new RegExp('.(js|json)$');

  if (href && expression.exec(href)) {
    return false;
  }

  if (src && expression.exec(src)) {
    return false;
  }

  return true;
}

exports.onPreRenderHTML = ({
  getHeadComponents,
  replaceHeadComponents,
  getPostBodyComponents,
  replacePostBodyComponents
}) => {
  if (process.env.NODE_ENV === 'production') {
    const filteredHeadComponents = getHeadComponents().filter(
      filterJavascriptItems
    );
    replaceHeadComponents(filteredHeadComponents);
    const filteredPostBodyComponents = getPostBodyComponents().filter(
      filterJavascriptItems
    );
    replacePostBodyComponents(filteredPostBodyComponents);
  }
};

This approach is based on @jordanoverbye https://github.com/jordanoverbye/gatsby-plugin-no-js

from gatsby-plugin-no-javascript.

itmayziii avatar itmayziii commented on June 15, 2024

@marvinrabe @mathiasha

This is now fixed with v2.0.5

from gatsby-plugin-no-javascript.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.