Git Product home page Git Product logo

Comments (10)

agusterodin avatar agusterodin commented on August 27, 2024

Same here. Console gets completely spammed indefinitely when running a project that uses this library.

from favicons.

DanielRuf avatar DanielRuf commented on August 27, 2024

@agusterodin see Marak/colors.js#285 (comment) for some possible solutions.

If needed I can prepare the relevant patch.

from favicons.

rsadr0pyz avatar rsadr0pyz commented on August 27, 2024

npx marak-free

from favicons.

agusterodin avatar agusterodin commented on August 27, 2024

I have no idea what that package is. Potentially dangerous given how weird things have been from Marak. Use caution when running commands with npx.

from favicons.

DanielRuf avatar DanielRuf commented on August 27, 2024

@agusterodin see https://unpkg.com/browse/[email protected]/ and https://unpkg.com/browse/[email protected]/index.js

from favicons.

xoxys avatar xoxys commented on August 27, 2024

Other seems to replace colors with chalk e.g. aws/aws-cdk#18329 maybe that's a more reliable solution.

from favicons.

DanielRuf avatar DanielRuf commented on August 27, 2024

Other seems to replace colors with chalk e.g. aws/aws-cdk#18329 maybe that's a more reliable solution.

Not in most cases as this might lead to breaking changes. The returned strings are a bit different and parsers may behave differently. See for example cli-table/cli-table3#250 (comment)

The easier and faster fix is to pin the version since you can not remove or change already published package versions.

from favicons.

xoxys avatar xoxys commented on August 27, 2024

How does pinning solve the issue in a long term? In case of a future security issue you might end up locked, no idea if and how the colors package will be maintained in the future. Trust is easy to destroy and hard to recover 🤷 Just my two cents.

from favicons.

DanielRuf avatar DanielRuf commented on August 27, 2024

How does pinning solve the issue in a long term? In case of a future security issue you might end up locked, no idea if and how the colors package will be maintained in the future

The easier and faster fix

I never said "longterm" fix. The longterm solution would be to switch to something like chalk, which is actively maintained.

Alternatively switch to the fork (DABH is one of its previous contributors and maintainers): https://www.npmjs.com/package/@dabh/colors

from favicons.

xoxys avatar xoxys commented on August 27, 2024

Ok then we talk about the same thing now :) because what I said initially was

Other seems to replace colors with chalk e.g. aws/aws-cdk#18329 maybe that's a more reliable solution.

where more reliable means long term/permanent fix and not hotfix.

from favicons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.