Comments (3)
Good catch! It looks like normalized
doesn't even need to be included here since it's already added to plot_config
above. I also don't see why normalized
is in kwargs
at all instead of being a named argument. And other plot_config
options title
, x_label
, and y_label
seem to be undocumented, and I'm not sure they are really needed. I would suggest making normalized
a named argument when fixing this.
@ocraft Are you interested in submitting a PR?
from dvclive.
Sure, I've fixed that in the PR: #813. Interestingly, there was already a test for it, but only for "confusion_matrix" and "title", and this particular plot has such an argument, so the test passed. The plot's parameters themselves should remain, as they are useful; for example, the title is necessary to distinguish between two different plots of the same type in the same report. In other parts of the application, the "normalized" parameter is utilized, so I didn't change anything else.
from dvclive.
Interesting, thanks. The reason it passes for confusion_matrix
is that plot doesn't actually call any sklearn method, which is where the error gets raised.
from dvclive.
Related Issues (20)
- integrations: hf accelerate HOT 4
- Log metrics/models etc... to studio directly with Live or DVCLiveCallbacks in training script HOT 9
- integrations: lightning fabric
- `log_image` fails to save an image if the path was provided, but the `name` does not have an extension HOT 1
- 4.0 Checklist HOT 1
- Add user friendly warning/error messages and helpers for log_plot() HOT 3
- Foreach to run multiple experiments HOT 3
- DVCLive throws a weird warning when origin is not defined HOT 6
- Add docstrings HOT 2
- Invalid path causes `TypeError` due to shadowed builtin `type` HOT 2
- `Live.log_artifact` raises `ValueError` by logging to closed `stderr` when Tensorflow is imported first HOT 6
- `log_image`: log bounding boxes HOT 5
- Test falling for Huggingface
- Path not supported for some path arguments HOT 2
- Error RuntimeError: SQLite version is too old, please upgrade to >= (3, 8, 3) HOT 7
- Provide examples or quick code snippets in the public methods
- System metrics should be plotted with `timestamp` rather than `step`
- DVC Live hangs when pushing to remote HOT 3
- What is the proper way of enabling intermediate checkpointing when using pytorch lightning+dvc+dvclive? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dvclive.