Git Product home page Git Product logo

Comments (5)

dberenbaum avatar dberenbaum commented on June 19, 2024 1

@efiop It looks like in #10027, we should be using Coerce(int):

dvc/dvc/config_schema.py

Lines 263 to 265 in 5c31189

"timeout": int,
"read_timeout": int,
"connection_timeout": int,

Do we have tests for the config schema to catch these kind of issues?

from dvc.

1998jack1998 avatar 1998jack1998 commented on June 19, 2024 1

@efiop works great. Thank you for fast solving this issue!

from dvc.

1998jack1998 avatar 1998jack1998 commented on June 19, 2024

Thanks for fast response, I agree that value from config should be mapped to int.

from dvc.

efiop avatar efiop commented on June 19, 2024

@1998jack1998 Thanks for reporting!

@dberenbaum Nice catch! We do test those in python just to check that fs accepts those, but we don't really test the schema coerce rules that much as it is rare and might be excessive (aka we are lazy bums). Maybe I'm just lazy, but it doesn't seem worth it right now either.

from dvc.

efiop avatar efiop commented on June 19, 2024

@1998jack1998 Please feel free to give 3.40.1 a try. Thanks again!

from dvc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.