Git Product home page Git Product logo

Comments (6)

howardjohn avatar howardjohn commented on July 17, 2024

it's because it triggers a gateway status change. Probably could be optimized to not push on status change (or, at least, that field in status)

from istio.

spacewander avatar spacewander commented on July 17, 2024

What about adding special handling to the Gateway API resource in https://github.com/istio/istio/blob/master/pilot/pkg/bootstrap/config_compare.go, just like what we have done with the istio's resource?

I would like to submit this PR later if permitted.

from istio.

howardjohn avatar howardjohn commented on July 17, 2024

The thing that is tricky is we use pushes to trigger recomputing GW API resources. So while we don't use status at all for XDS generation, if we were to do something like if only status changed { skip } the status would fall out of date.

from istio.

spacewander avatar spacewander commented on July 17, 2024

As long as the status is produced by us, we don't need to watch the status change because the status is the reason for our processing.

There may be two cases that we need to watch the status change:

  1. we need to confirm the status is written into API server, and do something after it. Since the status writing is async, for now, I think there is no place that requires this confirmation.
  2. some tools other than the istiod will produce status that needs to be consumed by istiod. Although I may miss something in the Gateway API, but it seems that there is no such requirement so far.

from istio.

howardjohn avatar howardjohn commented on July 17, 2024

Yeah but the part that writes the status and the part that reads the events doesn't really know who wrote it which makes it challenging.

In Gateway API most objects (routes) can have multiple owners as well. Also, someone could just delete the status - we are expected to add it back

from istio.

spacewander avatar spacewander commented on July 17, 2024

The computing of Gateway API resources in the event loop can be split into two parts:

  1. translate into internal representation
  2. generate xds

Since we want to add the status back, we can't skip part one for the status only change. But we can skip the second part.

For example, we can add a statusOnly field in the PushRequest. If the request only contains status only changes, we can skip the xds generation.

As Gateway API depends on the status widely, it's worth skipping the xds generation for status only changes, which may be a lot.

from istio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.