Comments (6)
it's because it triggers a gateway status change. Probably could be optimized to not push on status change (or, at least, that field in status)
from istio.
What about adding special handling to the Gateway API resource in https://github.com/istio/istio/blob/master/pilot/pkg/bootstrap/config_compare.go, just like what we have done with the istio's resource?
I would like to submit this PR later if permitted.
from istio.
The thing that is tricky is we use pushes to trigger recomputing GW API resources. So while we don't use status at all for XDS generation, if we were to do something like if only status changed { skip }
the status would fall out of date.
from istio.
As long as the status is produced by us, we don't need to watch the status change because the status is the reason for our processing.
There may be two cases that we need to watch the status change:
- we need to confirm the status is written into API server, and do something after it. Since the status writing is async, for now, I think there is no place that requires this confirmation.
- some tools other than the istiod will produce status that needs to be consumed by istiod. Although I may miss something in the Gateway API, but it seems that there is no such requirement so far.
from istio.
Yeah but the part that writes the status and the part that reads the events doesn't really know who wrote it which makes it challenging.
In Gateway API most objects (routes) can have multiple owners as well. Also, someone could just delete the status - we are expected to add it back
from istio.
The computing of Gateway API resources in the event loop can be split into two parts:
- translate into internal representation
- generate xds
Since we want to add the status back, we can't skip part one for the status only change. But we can skip the second part.
For example, we can add a statusOnly
field in the PushRequest. If the request only contains status only changes, we can skip the xds generation.
As Gateway API depends on the status widely, it's worth skipping the xds generation for status only changes, which may be a lot.
from istio.
Related Issues (20)
- TLS Gateway Passthrough requires disabling mTLS HOT 4
- Autoregistration locality broken for VM workloads HOT 3
- SE may break api-server connectivity in ambient HOT 4
- [release-1.22] Make sure we always Take() the netns, always remove the IP, and fence with more tests HOT 1
- Envoy CPU pprof broken due to tcmalloc HOT 6
- ServiceEntry does not affect when using Ambient Mode. HOT 1
- Bug: When the port is not explicitly designated as HTTP by other services, the protocol sniffing server port cannot route services using only the host. HOT 6
- [release-1.22] Fixed when a router associated service created, the proxy.MergedGatew…
- [release-1.21] Fixed when a router associated service created, the proxy.MergedGatew…
- [release-1.20] Fixed when a router associated service created, the proxy.MergedGatew… HOT 1
- Pilot goroutine leak and memory leak HOT 9
- Checking inject inconsistent
- Test CNI ambient flow with integration tests HOT 2
- Native Sidecars draining erroneously sending connection: close for outbound requests HOT 4
- operation name inconsistent depending on VirtualService configuration
- ambient: improper handling of duplicate hostnames
- Invalid pod lifecycle with native sidecars HOT 6
- Unable to limit the upstream connections from sidecar to app container HOT 3
- TreatMissingHeaderAsEmpty for regex matchers HOT 1
- Native Sidecar pods not terminating if they never initially became ready HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from istio.