Git Product home page Git Product logo

Comments (4)

howardjohn avatar howardjohn commented on June 26, 2024

istio/istioctl/pkg/precheck/precheck.go

Lines 187 to 190 in 4246548

checkVerify := func(tls *networking.ClientTLSSettings) bool {
return tls != nil && tls.CaCertificates == "" && tls.CredentialName == "" &&
tls.Mode != networking.ClientTLSSettings_ISTIO_MUTUAL && !tls.InsecureSkipVerify.GetValue()
}
is the logic. I would think that is NOT impacted and should not log.

However, the TLS config can be in 4 places: {main,subset}x{global,port level}.. maybe one of them? Do you have the full DR so I can test?

from istio.

howardjohn avatar howardjohn commented on June 26, 2024 
$ ./istio-1.21.0/bin/istioctl x precheck  --from-version 1.20
✔ No issues found when checking the cluster. Istio is safe to install or upgrade!
  To get started, check out https://istio.io/latest/docs/setup/getting-started/

with

apiVersion: networking.istio.io/v1alpha3
kind: DestinationRule
metadata:
  name: bookinfo-ratings
spec:
  host: ratings.prod.svc.cluster.local
  trafficPolicy:
    loadBalancer:
      simple: LEAST_REQUEST
    tls:
      caCertificates: /etc/ssl/certs/ca-certificates.crt
      mode: SIMPLE
      sni: whatever.zendesk.com

from istio.

Stono avatar Stono commented on June 26, 2024

Ah it's because it's a complex DR (as we're doing tls origination) under portLevelSettings:

apiVersion: networking.istio.io/v1beta1
kind: DestinationRule
metadata:
  name: zendesk
  namespace: zendesk-controller
spec:
  exportTo:
  - .
  host: autotraderukpreprod.zendesk.com
  trafficPolicy:
    connectionPool:
      http:
        h2UpgradePolicy: DO_NOT_UPGRADE
      tcp:
        connectTimeout: 2s
        maxConnectionDuration: 5m
        tcpKeepalive:
          interval: 30s
          time: 30s
    portLevelSettings:
    - connectionPool:
        http:
          h2UpgradePolicy: DO_NOT_UPGRADE
        tcp:
          connectTimeout: 2s
          maxConnectionDuration: 5m
          tcpKeepalive:
            interval: 30s
            time: 30s
      port:
        number: 443
      tls:
        mode: DISABLE
    - connectionPool:
        http:
          h2UpgradePolicy: DO_NOT_UPGRADE
        tcp:
          connectTimeout: 2s
          maxConnectionDuration: 5m
          tcpKeepalive:
            interval: 30s
            time: 30s
      port:
        number: 80
      tls:
        caCertificates: /etc/ssl/certs/ca-certificates.crt
        mode: SIMPLE
        sni: autotraderukpreprod.zendesk.com

from istio.

howardjohn avatar howardjohn commented on June 26, 2024

thanks! i'll send a fix

from istio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.