getObject about isomorphic-git HOT 5 CLOSED

@mojavelinux thoughts?

from isomorphic-git.

I like the fact that you're using the same function to get each object in succession since that reflects how git actually works.

I would think you'd need to specify the type/format for the last call in your example:

let blob = await git.getObject({fs, dir, ref: file.oid, type: 'content'})

right? otherwise, I'd expect to get a BlobDescription based on your proposal.

I'm worried we're overloading the meaning of "type" (see https://git-scm.com/docs/git-cat-file). Type is already used for the object type (tree, blob, etc). Perhaps format instead?

from isomorphic-git.

otherwise, I'd expect to get a BlobDescription based on your proposal.

True! It would probably be blob.data.toString() or something.

Perhaps format instead?

I thought I did call it format... no worries! I agree that 'type' already has a meaning. I definitely won't call it type. :)

from isomorphic-git.

👍

from isomorphic-git.

I changed the names for more consistency / descriptiveness. Instead of getObject it is readObject (because presumably we will add a writeObject at some point) and instead of 'raw' and 'plain' I called them 'deflated' and 'wrapped'. Soon as the CI tests pass it should be published!

https://isomorphic-git.github.io/docs/readObject.html

from isomorphic-git.