Disable failing test that require credentials on Azure DevOps about isomorphic-git HOT 14 CLOSED

@seanpoulter can you maybe add a PR with those tests disabled on separated PR/branch. So we can merge right away? Just use cherry-pick on different branch.

from isomorphic-git.

Interesting. We're using a hard-coded username and password/PAT trying to force push to ADO which is throwing a HTTP 401.
https://github.com/isomorphic-git/isomorphic-git/blob/main/__tests__/test-hosting-providers.js#L85-L103

from isomorphic-git.

Did the PAT expire in ADO?

from isomorphic-git.

I have no idea what those are. Where can I check this? Will migration to GitHub action fix this?

from isomorphic-git.

It looks like we are using a username and password to authenticate to Azure DevOps in the test:

The authentication method was deprecated in 2020.
https://learn.microsoft.com/en-us/azure/devops/repos/git/auth-overview?view=azure-devops#alternate-credentials

Azure DevOps no longer supports Alternate Credentials authentication since the beginning of March 2, 2020.

The authentication method was removed in January 2024:
https://devblogs.microsoft.com/devops/azure-devops-will-no-longer-support-alternate-credentials-authentication/

This feature will be fully deprecated in January 2024.

The test analytics don't go back that far but it has been failing for the last 14 days.
https://dev.azure.com/isomorphic-git/isomorphic-git/_test/analytics?definitionId=1&contextType=build

The solution is to change the authentication method for the test case.

--

Next steps:

• Decide on the authentication method
• Confirm the user has the least possible permissions to run the test
• Decide if we want to keep the secret hard-coded or hide it
• Update the test case to use the new authentication method

--

To answer your two questions:

Where can I check this?

If we had a PAT set up, you could follow these docs:
https://learn.microsoft.com/en-us/azure/devops/organizations/accounts/use-personal-access-tokens-to-authenticate?toc=%2Fazure%2Fdevops%2Forganizations%2Ftoc.json&view=azure-devops&tabs=Windows

Will migration to GitHub action fix this?

No.

from isomorphic-git.

If this to test the git server, then maybe we can use Docker for this.

from isomorphic-git.

from isomorphic-git.

I think that for now we need to disable those tests so we can merge open PR. We will think what to do with them when we migrate to GitHub actions.

from isomorphic-git.

I've disabled the test in #1879. If/when we get the GitHub Actions set up we get use this issue and get those tests back in.

from isomorphic-git.

We need to get out of this deadlock. @jcubic, if there is no way to fix this issue, can't we disable it for now in the whole repo? All other PR are blocked.

from isomorphic-git.

PR is up

from isomorphic-git.

I think we can close this one.

from isomorphic-git.

Do you want to keep it open to fix it and update the authentication to use a PAT in CI?

from isomorphic-git.

Can you remind me what is PAT?

from isomorphic-git.