Git Product home page Git Product logo

Comments (3)

hansenms avatar hansenms commented on August 14, 2024

We are very explicit about which version of ISMRMRD we build against. It is captured in the dependencies/ismrmrd file. So every single commit in this repo says what version of ISMRMRD to use.

The conda packages we make in the Gadgetron explicitly targets a version of the ISMRMRD library.

I know that you guys run your own builds and in there you should be explicit about which versions you are targeting and test that those work together. More could probably be done to use CMake to restrict the versions, but unless you have a suggestion for how that should work, I am not sure this issue is actionable.

Do you have some idea of what you would like to see implemented here?

from siemens_to_ismrmrd.

KrisThielemans avatar KrisThielemans commented on August 14, 2024

sure. modify

find_package(ISMRMRD REQUIRED)

to

find_package(ISMRMRD REQUIRED 1.5.0)

Of course, this might not be fine-grained enough as these projects evolve together, but it's better than nothing...

from siemens_to_ismrmrd.

hansenms avatar hansenms commented on August 14, 2024

Then please put up a PR.

from siemens_to_ismrmrd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.