Comments (11)
Hi @mshearer123
If you enable the Info level you gonna be able to see which files changed, their modules and the impact of the changes.
Just add -i when you run your command
./gradlew testChangesModules -i
Not sure if it's your case, but normally when you're setuping the plugin for the first time, it will trigger the task for all modules since you're modifying the root build.gradle
. Next PR's should be fine
from change-tracker-plugin.
Just the remote name like upstream
or origin
.
from change-tracker-plugin.
Thanks @ismaeldivita
unfortunately we use this sort of code below in settings.gradle to allow modules within folders
file("features").safeListFiles { dir ->
include("features-${dir.name}")
project(":features-${dir.name}").projectDir = dir
}
We'll revisit if we can change that
from change-tracker-plugin.
This code seems to just register the modules inside "features" folder automatically. I can't see a problem and this should not impact on the plugin.
The plugin should work fine with nested sub-projects like this.
:app
:foo
:foo:bar
:foo:bar:z
If you could share more details or provide a sample repo reproducing the problem I can take a look.
from change-tracker-plugin.
I think it's the filepath throwing it.
for
/features/feature1
this line in the project locator
(projectPaths.indices).all { projectPaths[it] == filePaths[it] }
will compare features-feature1
with features
This is obviously incorrect, but works for our setup
(projectPaths.indices).all { projectPaths[it] == (filePaths[it] + "-" + filePaths[it + 1]) }
from change-tracker-plugin.
Sample with the issue - https://github.com/mshearer123/ChangeTrackerExample
in branch test
with a change in only feature1
output from task
Changed Files
- features/feature2/src/main/java/com/mas/feature2/SecondFragment.kt
Changed Projects
- null
Affected Projects
- project ':app'
- project ':features-feature1'
- project ':features-feature2'
from change-tracker-plugin.
Got it
I shouldn't use the project path
to search for a module, but the projectDir
instead.
I'll fix it
from change-tracker-plugin.
@ismaeldivita Brilliant.
One other thing, the remote
value, does that expect something like https://github.com/mshearer123/ChangeTrackerExample.git
?
from change-tracker-plugin.
Let me know if 0.7.3 fixes your problem
from change-tracker-plugin.
@ismaeldivita works perfectly, thanks very much
from change-tracker-plugin.
Nice, I'll close this one.
from change-tracker-plugin.
Related Issues (10)
- Branch not found on CI HOT 2
- Let reevaluate option take paths HOT 3
- Compatibility with gradle 7 HOT 3
- Add ability to toggle between changed modules & affected dependencies HOT 1
- Changed 3 modules and got java.lang.StackOverflowError HOT 4
- Logging diffs HOT 2
- Support configuration per task
- The plugin always detekt all modules as changes HOT 8
- Add support to ignore file by path HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from change-tracker-plugin.