Question about custom interception/retry functionality about apikit HOT 9 CLOSED

@ishkawa

How can I implement retry ?
That implement does not work now....

Regards,

from apikit.

Hi jyounus,

APIKit does not have retry functionality because it aims at providing type-safe single request. IMO, rich functionality for multiple request makes this library complex, so I think combining multiple request is responsibility of developers.

Next, let's think about your use case. To implement auto-retrying, wrapping sendRequest in a subclass is easiest. Here's example of implementation:

class CustomSession: Session {
    override func sendRequest<T: RequestType>(request: T, handler: (Result<T.Response, APIError>) -> Void = {r in}) -> NSURLSessionDataTask? {
        // 1. send request
        return super.sendRequest(request) { [weak self] result in
            // 2. check the error
            if case .Failure(let error) = result where /* check if the error is E1101 */ {
                // 3. refresh token if the error is E1101
                self?.refreshTokenWithHandler { [weak self] refreshedToken in
                    // 4. retry reqeust
                    self?.sendRequest(request, handler: handler)
                }
                return
            }

            handler(result)
        }
    }

    private func refreshTokenWithHandler(handler: String -> Void) {
        ...
    }
}

Note that Session.sharedSession is not a CustomSession.

from apikit.

Hey ishkawa,

Thanks for the reply! I will try it out and get back to you if I have any issues.

Regarding Session.sharedSession, any chance you could change "static" into "class" for your variables/methods? In theory, this should allow me to subclass Session and override the sharedSession property.

from apikit.

Sounds good 👍 I'll work on this tomorrow.

Unlike static property, class property cannot be stored property, so overriding this property will be something like this:

class CustomSession: Session {
    private static var privateSharedSession: Session = ...

    override class var sharedSession: Session {
        return privateSharedSession
    }
}

I expect class property supports stored property in the future version of Swift, because the compiler says:

Class stored properties not yet supported in classes

from apikit.

Ah okay, fair enough. No worries, for now I've just duplicated the method and named it something else in my subclass, so it's working fine for me. Obviously not ideal, but that can be improved whenever Swift supports this feature. :)

from apikit.

This change has been released in 1.4.0!

from apikit.

Nice one! I'm currently using your 2.x beta branch, but I will switch to 1.4 and give it a try!

Thanks man, appreciate your efforts on this library! :D

from apikit.

Shipped 2.x beta 4 yesterday. Now, this change is also available on 2.x branch!

from apikit.

Awesome! Thanks :D

from apikit.