Comments (4)
Thanks!
from olctools.
Hmn. Well, I made the change and it's still producing 796RXF22+. That's...strange :|
from olctools.
I think you've fixed it. The CRAN library (0.2.1) does this (sadness):
> shorten_olc("796RXG22+", 14.95125,-23.5001)
[1] "22+"
> recover_olc("22+", 14.95125,-23.5001)
[1] "65GG3222+"
When I install using devtools::install_github("ironholds/olctools") I get (happiness):
> shorten_olc("796RXG22+", 14.95125,-23.5001)
[1] "22+"
> recover_olc("22+", 14.95125,-23.5001)
[1] "796RXG22+"
I'd suggest adding two test cases to the test_shortener.R code:
expect_equal(recover_olc("22+", 42.899, 9.012), "8FJFW222+")
expect_equal(recover_olc("22+", 14.95125 -23.5001), "796RXG22+")
from olctools.
Hmn - okay, that's super weird. Ah well! Good calls on the regression tests, too. I'll push this out overnight to CRAN, bundled with the NA support!
from olctools.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from olctools.