Git Product home page Git Product logo

Comments (3)

mognify avatar mognify commented on June 2, 2024

i wonder if this method is even called anywhere lol, checking

from java-ipfs-http-client.

mognify avatar mognify commented on June 2, 2024

maybe it's something more advanced in Java than what i know, but the note states that it's supposed to return the current IPFS object with modified timeout(s)

but it returns a new object

if it's supposed to return a new object, then yeah it should be static
if it's supposed to return the current object, then it should just be a setter that returns the current object and not a new object (this latter part im not 100% certain of, it's just how i'd write it)


oh, the timeout fields are final, so it's not a setter method
it has to return a new object because the fields are final
i remember something about this when learning Rust... Rust's variables are all final by default (immutable), i forgot why tho
https://youtu.be/iFdh4sPC5Tg?t=188

oh it's just for safety when passing it around

so it seems like it's all correct, just the note is kind of tricky for me lol

from java-ipfs-http-client.

kevodwyer avatar kevodwyer commented on June 2, 2024

Fixed merged

from java-ipfs-http-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.