Git Product home page Git Product logo

Comments (14)

pgte avatar pgte commented on May 26, 2024 2

@haadcode that's a great point, it really forbids us from using a non-local node with this package, but I think this is a limitation of ipfs-api and the HTTP API, not this package. Somehow, the IPFS API should allow to open raw private streams to specific nodes.

Also, I believe that encryption and authentication should not be a concern of this package, it should be addressed further up the stack, maximising separation of concerns.

As an alternative to fixing ipfs-api, I think there's nothing preventing you from building this mechanism on top of this package by "broadcasting" p2p messages in the way you described...

@haadcode @diasdavid thoughts?

from ipfs-pubsub-room.

pgte avatar pgte commented on May 26, 2024 1

@haadcode that's super, I think they may be very useful in some of upcoming work: I think I'm going to need direct communication, presence, but not broadcast.

I'd be super glad these repos come join the ipfs-shipyard org!

from ipfs-pubsub-room.

daviddias avatar daviddias commented on May 26, 2024
08:01 <@daviddias> the reason why it uses libp2p is so that all the comms between 2 peers are encrypted e2e
08:02 <@daviddias> if you use PubSub as you propose, then any peer can eavesdrop in other peers messages

from ipfs-pubsub-room.

haadcode avatar haadcode commented on May 26, 2024
08:03 <@haad> daviddias: yup, in my proposal the encryption would have to happen on app/user-layer

from ipfs-pubsub-room.

haadcode avatar haadcode commented on May 26, 2024

@pgte totally agreed. I think I'll go ahead and create the module as laid out ^ and see what that gets us (not sure when I get to work on it though). Ideally, as noted by all of us I think, we should have a way to hook into libp2p streams/connections directly from the API to get the benefits of libp2p.

from ipfs-pubsub-room.

nezzard avatar nezzard commented on May 26, 2024

Any updates?

from ipfs-pubsub-room.

pgte avatar pgte commented on May 26, 2024

Nope. This depend on ipfs-api, which would have to be standardised and implemented in go-ipfs and js-ipfs.

from ipfs-pubsub-room.

nezzard avatar nezzard commented on May 26, 2024

For now, we can use it only with js-ipfs?

from ipfs-pubsub-room.

pgte avatar pgte commented on May 26, 2024

from ipfs-pubsub-room.

haadcode avatar haadcode commented on May 26, 2024

Update on OrbitDB side is that I ended up first taking out the libp2p functionality from ipfs-pubsub-room and created a module for 1-to-1 communication https://github.com/haadcode/ipfs-pubsub-1on1. Note that it's not a secure channel in the way ipfs-pubsub-room has: anyone can join the pubsub topic and listen in on it. This will change in the future, however.

Second, as ipfs-pubsub-room then only had the room notifications functionality left and we didn't want to use a fork, I created another module to do only that: https://github.com/haadcode/ipfs-pubsub-peer-monitor.

Essentially, those two modules have the same functionality as ipfs-pubsub-room but broken down per "abstraction", works with js-ipfs-api but also provide less security guarantees. I've created them in order to be able to keep moving on in OrbitDB, but the overall goal here is to be able to use ipfs-pubsub-room room in the long run once we have the libp2p connections available through js-ipfs-api.

@pgte you may want to check those modules and see what you think. Would be also more than happy to transfer the repos to shipyard if you feel they benefit the community and work done here.

from ipfs-pubsub-room.

haadcode avatar haadcode commented on May 26, 2024

@pgte tried to transfer the repos but got an error "You don't have the permission to create repositories on ipfs-shipyard".

Mind adding me to the org (would also love to keep admin/write access to the repos I'm transferring)?

from ipfs-pubsub-room.

pgte avatar pgte commented on May 26, 2024

It seams like I don't have enough permissions for that. @diasdavid an you help on this?

from ipfs-pubsub-room.

daviddias avatar daviddias commented on May 26, 2024

Done :)

from ipfs-pubsub-room.

haadcode avatar haadcode commented on May 26, 2024

@diasdavid @pgte thank you! ♥️

The repos have been transferred respectively at:

I believe I'm still the only one who can publish on npm and would be happy to add another maintainer for that, but you can also just give a shout and I'll publish when needed. We can cross that bridge when we get there.

from ipfs-pubsub-room.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.