Runtime error from update to Storage 2.0.0 about ionic-starter-super HOT 12 CLOSED

I have opened a PR here with the changes that worked for me.

from ionic-starter-super.

Thanks, we're not quite production ready with this repo yet, wanted to get some feedback over the last month or so. We'll tend to it a bit now that things are more stable soon

from ionic-starter-super.

@ryanrain
So in #2, could you provide us newbies with more information on the correct way to do this step. I tried but kept getting red squiggly lines. In my app.module.ts that I got just a few minutes ago, I did step #1. The providers() in @NgModule was empty already between the parenthesis. Also, in @NgModule, I see this: IonicModule.forRoot(MyApp) NOT what is written in your #4. Which one is correct?

from ionic-starter-super.

@ryanrain The instructions given above DO NOT help or solve anything, they're just the instructions on how to update to ionic-storage 2.0 for vanilla Ionic apps.

I have no idea why they were posted, and I can confirm that even after following those steps my app still isn't working. Its like they completely changed the way the Storage module works and have invalidated the super starter.

For now we'll wait for an update to the super starter before being able to update to 2.2.0...I wish I knew more about the internals of the Ionic Storage module and could fix this

from ionic-starter-super.

@LiveListMobile @mikehamil10
unfortunately i too am just starting to use ionic, and so can't yet be of much help here. if i could i would have submitted a nice pull request... other templates, such as blank, or tabs, still work:
ionic start myApp blank --v2

from ionic-starter-super.

Take a look at the new documentation here, can you try changing it to that in the meantime and let me know if it works for you? We'll have to do a patch anyways but I can't get to it for a bit.

Note the change to IonicStorageModule and specifying it in the imports rather than as a provider.

http://ionicframework.com/docs/v2/storage/

from ionic-starter-super.

@mlynch many thanks! reading code in this repo is super (sorry) useful to those of us who are just starting to use ionic etc., and in need of guidance re: best practices.
sidenote: a fork i made with ngrx/store and ngrx-store-ionic-storage: https://github.com/ryanrain/ionic-starter-super

from ionic-starter-super.

@pwespi I've copied the changes you have made in your PR and they have worked for me also, nice work,

from ionic-starter-super.

@pwespi so sad :-/ as it still doesn't work for me as everything seems to be correctly setup.

Error is :

Runtime Error
Can't resolve all parameters for Storage: (?).

Environment :
Ionic Framework: 2.2.0
Ionic Native: 2.4.1
Ionic App Scripts: 1.1.4
Angular Core: 2.4.8
Angular Compiler CLI: 2.4.8

Dependencies:
...
"@angular/platform-browser-dynamic": "2.4.8",
"@angular/platform-server": "2.4.8",
"@ionic/storage": "2.0.0",
"ionic-angular": "2.2.0",
"ionic-native": "2.4.1",
...

from ionic-starter-super.

@slegouffe Sorry to hear that. Maybe try starting again from a bare app with the super template ionic start super-storage-test super --v2 and replace the app.module.ts with this.

from ionic-starter-super.

@pwespi: another confirmation here. The updated ionic docs include the correct way to reference the Storage module.

from ionic-starter-super.

Fixed in #82

from ionic-starter-super.