0.0.14 Push issues about ionic-cloud-angular HOT 5 CLOSED

@sagivf Haha, yep. Ionic is venturing into uncharted territories and bringing a bunch of people with! I also think things are on the right track and I believe it's because of people like you. Thanks so much for working with me. This is the feedback we've needed. 🍻

from ionic-cloud-angular.

1. Push options are part of the config now. But, there aren't many options. If you're looking for where to put your onNotification handler, it's done through the event emitter (for now... later it may be an observable).

   const cloudSettings: CloudSettings = {
     'core': {
       'app_id': "YOUR-APP-ID"
     },
     'push': {} // PushOptions
   };

   import {EventEmitter} from '@ionic/cloud-angular';

   constructor(emitter: EventEmitter)

   emitter.on('push:notification': (data) => { });

2. The onReady function/callback is not needed, correct.

3. The console errors in the plugin are also correct -- you cannot do native push notifications in the browser. They are "uncaught" promise errors, but they are still ugly. Maybe I can clean them up somehow.

from ionic-cloud-angular.

Thanks for the detailed response @dwieeb, much appreciated.
It works nicely :)
Regarding number 3, till proper mocking or better yet an ionic-browser push implementation is created catching the errors our selves is ok.
Generally speaking I think that all the ionic-native cordova plugins should come with a browser mock.\

I believe that Ionic's long time strength in my view is enabling web developers to use the tools they know and love.

from ionic-cloud-angular.

I agree. We're very interested in implementing browser pushes & deploy functionality for the browser. The browser is a proper platform for Ionic and I think it will do us well to treat it as one for Ionic Cloud.

It sounds like these issues are resolved. If they are not, no worries. I'll reopen.

from ionic-cloud-angular.

Thanks @dwieeb, not related to this issue, but Ionic and Ionic Platform have given me a lot of headaches over the past two years :) (to be fare a lot of the headache is Apple/Cordova related), but the dedication and responsiveness from you guys has kept me going and I do believe things are on the right track - keep it up and thanks for the hard work 👍

from ionic-cloud-angular.