Comments (2)
Btw we no longer use keyrune just SVG symbols so that font is no longer required for the app just fyi if you care about not having extra fonts installed 👍 We should probably deprecate the text in the GUI that mentions a "keyrune" code.
As to the issue, at the time my thinking was if someone is going to force the symbol manually they can just reference the folder code (more typically the set code, since something like 95% of symbol codes are the same as the set code or parent set code outside the labyrinth that is random promo sets). Alternatively, I could use the manifest mapping primarily and use the folder name as a fallback? I don't think there would be any conflicting overlaps off the top of my head, but I can't be totally certain 😳
from proxyshop.
Btw we no longer use keyrune just SVG symbols so that font is no longer required for the app just fyi if you care about not having extra fonts installed 👍 We should probably deprecate the text in the GUI that mentions a "keyrune" code.
Interesting! I had sorta assumed as much when you started maintaining your own collection of symbols! (Which made it a bit more confusing to me when the custom creator seemed to route the set codes while the override didn't, haha)
As to the issue, at the time my thinking was if someone is going to force the symbol manually they can just reference the folder code (more typically the set code, since something like 95% of symbol codes are the same as the set code or parent set code outside the labyrinth that is random promo sets).
Honestly, this works fine for me. Sure applying the manifest mapping and then folders as a fallback would be "nice", but I don't think it's wildly important given my guess at how many people would actually use the feature. My only other thoughts were to like the ones in .extras
or .alt
.
from proxyshop.
Related Issues (20)
- [BUG] - Cards with a colon in its name aren't outputted properly HOT 3
- [BUG] - Banned cards due to non-appropiate imagery aren't found by new scryfall search method HOT 2
- [BUG] - "Lieutenant" ability not being italicized due to regex HOT 1
- [BUG] - Kivy not (yet) working with Python 3.11 HOT 3
- [BUG] - New scryfall search includes art cards on the search results and those aren't valid to render HOT 4
- [BUG] - Discord invitation link on README.MD expired HOT 1
- [BUG] - Hybrid mana creatures throw error while enabling layers HOT 2
- [BUG] - Italics Issue with some 40K cards HOT 1
- [BUG] - Hybrid cases like Asmoranomardicadaistinaculdacar HOT 1
- [BUG] - [RuntimeError] Unable to install project dependencies (kivy): HOT 3
- Windows 11 says the executable is a virus. HOT 2
- [BUG] - Unable to insert collector info HOT 4
- [BUG] - Update failure - The OAuth client was deleted. HOT 1
- extended art planeswalker template won't render HOT 2
- [FEAT] - Add support for loyalty +/- ability text HOT 1
- [FEAT] - Proxyglyph font is missing the 1,000,000 mana symbol HOT 3
- [BUG] - Incorrect font sizing on Normal Token Oracle Text. HOT 3
- [BUG] - Saga templating with reminder text off
- [FEAT] "Spree" Support HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from proxyshop.