Git Product home page Git Product logo

Comments (2)

Investigamer avatar Investigamer commented on June 26, 2024

Btw we no longer use keyrune just SVG symbols so that font is no longer required for the app just fyi if you care about not having extra fonts installed 👍 We should probably deprecate the text in the GUI that mentions a "keyrune" code.

As to the issue, at the time my thinking was if someone is going to force the symbol manually they can just reference the folder code (more typically the set code, since something like 95% of symbol codes are the same as the set code or parent set code outside the labyrinth that is random promo sets). Alternatively, I could use the manifest mapping primarily and use the folder name as a fallback? I don't think there would be any conflicting overlaps off the top of my head, but I can't be totally certain 😳

from proxyshop.

nitz avatar nitz commented on June 26, 2024

Btw we no longer use keyrune just SVG symbols so that font is no longer required for the app just fyi if you care about not having extra fonts installed 👍 We should probably deprecate the text in the GUI that mentions a "keyrune" code.

Interesting! I had sorta assumed as much when you started maintaining your own collection of symbols! (Which made it a bit more confusing to me when the custom creator seemed to route the set codes while the override didn't, haha)

As to the issue, at the time my thinking was if someone is going to force the symbol manually they can just reference the folder code (more typically the set code, since something like 95% of symbol codes are the same as the set code or parent set code outside the labyrinth that is random promo sets).

Honestly, this works fine for me. Sure applying the manifest mapping and then folders as a fallback would be "nice", but I don't think it's wildly important given my guess at how many people would actually use the feature. My only other thoughts were to like the ones in .extras or .alt.

from proxyshop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.