Git Product home page Git Product logo

Comments (19)

Salakar avatar Salakar commented on May 21, 2024 1

You could have been internet famous hehe, changing now

from react-native-firebase.

Salakar avatar Salakar commented on May 21, 2024

Contributing guides and test app guides need doing also

from react-native-firebase.

jeveloper avatar jeveloper commented on May 21, 2024

By the way, there is a missing link on "Messaging" unless its meant to be marked as pending feature.

Thanks for the great work !

from react-native-firebase.

Salakar avatar Salakar commented on May 21, 2024

@jeveloper thanks for the heads up, FCM/messaging is implemented for android and has the full feature set that react-native-fcm lib has, ios will follow sometime this week.

from react-native-firebase.

jeveloper avatar jeveloper commented on May 21, 2024

Hey
Thanks for comment and good work.
Curious if you can just re-use rn-fcm , what would make implementing the same features better in this lib?

thanks

from react-native-firebase.

Salakar avatar Salakar commented on May 21, 2024

The code in messaging is based off rn-fcm, having it internal allows more control over the features and api as well as providing an all in one solution to get started with react-native and firebase.

from react-native-firebase.

jeveloper avatar jeveloper commented on May 21, 2024

ahh gotcha :)

from react-native-firebase.

Salakar avatar Salakar commented on May 21, 2024

@jeveloper and on that note, just finished ios messaging, so will push up and do another release shortly

from react-native-firebase.

jeveloper avatar jeveloper commented on May 21, 2024

You rock man !!

from react-native-firebase.

SamMatthewsIsACommonName avatar SamMatthewsIsACommonName commented on May 21, 2024

Hey a couple of small things I noticed on the ios installation docs, there is still a referecne to firestack on the library image:
screen shot 2017-03-23 at 14 10 23

Also the podfile example at the bottom of the instructions is different to the one generated by link which is of the form:

target 'APPLICATION_NAME' do
  # Uncomment the next line if you're using Swift or would like to use dynamic frameworks
  # use_frameworks!
  # Pods for 'APPLICATION_NAME'
end

# RNFirebase
pod 'Firebase/Auth'
pod 'Firebase/Analytics'
pod 'Firebase/AppIndexing'
pod 'Firebase/Core'
pod 'Firebase/Crash'
pod 'Firebase/Database'
pod 'Firebase/DynamicLinks'
pod 'Firebase/Messaging'
pod 'Firebase/RemoteConfig'
pod 'Firebase/Storage'

Is this as it should be? Cheers

from react-native-firebase.

Salakar avatar Salakar commented on May 21, 2024

Need a new screenshot or 2 then, think there's another one somewhere else also

I updated the pod template and the pod script a while back, docs not been updated to reflect, so that needs doing also

from react-native-firebase.

Salakar avatar Salakar commented on May 21, 2024

@SamMatthewsIsACommonName #10 and #17 also missing from docs i believe

from react-native-firebase.

SamMatthewsIsACommonName avatar SamMatthewsIsACommonName commented on May 21, 2024

Amazingly I need to research how to do a pull request haha... But I just mocked this up quickly that could be used?
screen shot 2017-03-23 at 14 17 57

from react-native-firebase.

Salakar avatar Salakar commented on May 21, 2024

Danke, updated images for section a and b, still need an image for c if you have one?

from react-native-firebase.

SamMatthewsIsACommonName avatar SamMatthewsIsACommonName commented on May 21, 2024

Oh yup will make now

from react-native-firebase.

Salakar avatar Salakar commented on May 21, 2024

Thanks, updated: https://github.com/invertase/react-native-firebase/blob/master/docs/installation.ios.md

from react-native-firebase.

SamMatthewsIsACommonName avatar SamMatthewsIsACommonName commented on May 21, 2024

Sorry that one still had my document path could you please use this one? I tried to do the old 'delete before you noticed' haha
screen shot 2017-03-23 at 14 41 20

from react-native-firebase.

Salakar avatar Salakar commented on May 21, 2024

cc @greena13 as you're thinking about looking into JSDocs 😸

from react-native-firebase.

Salakar avatar Salakar commented on May 21, 2024

Closing this now as we've moved over to the fancier docs.

from react-native-firebase.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.