Comments (8)
Pull request #23
from cache-tort-git.
Can you please provide output of
zwrite ^Git from namespace where error happens
from cache-tort-git.
This file really not exists, the problem is the "OnBeforeLoad" from %SourceControl.Git is executed before creating the file also.
from cache-tort-git.
I don't think that this is the problem OnBeforeLoad should not throw error if there are no external file.
from cache-tort-git.
Yes, i agree. The problem happens when the " LoadIfOutdated " method tries to load the file and it does not exist. I think we can fix this by validating method if the file actually exists.
from cache-tort-git.
Ok, it's resolved but my last commit resolved a potencial bug too.
You can merge?
from cache-tort-git.
I think we don't need to check that file exists in LoadIfOutdated because IsRoutineOutdated should return false if there is no corresponding file on disk, so there is no need to merge.
from cache-tort-git.
In my opinion the most correct is to validate if the file or routine exists and don't set a fictious date to this.
So for me the responsibilities of validations are confused , if we think of quality as correct code would be to separate these validations .
from cache-tort-git.
Related Issues (20)
- Versioning CSP Application HOT 5
- Git > Export All does not export updated cls files after importing new project.xml from Studio HOT 3
- make import on studio item open optional
- CSP folder don't import if it does not exist in local directory HOT 6
- Project hooks HOT 4
- Git holds xml instead of actual code HOT 5
- Lack of timestamps -> always skips import HOT 8
- we should skip generated classes HOT 6
- add stash save, stash pop, stash list menu items
- support export/import mappings via sc-list.txt HOT 2
- ERROR #1054: Invalid expression when importing package in 2013.1.1 HOT 1
- Handle $$$ClassDoesNotExist error when deleting classes HOT 1
- Add /skipstorage=1 as a default qualifier HOT 1
- What is procedure for updating plugin to different version? HOT 1
- Force Exprort All, ERROR #6304: Unable to export item HOT 2
- Git Plugin only allows to add 10 routines at a time HOT 4
- Error adding Routines to control manager HOT 4
- Installation instructions HOT 2
- Can't get it up HOT 4
- better support across upgrades
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cache-tort-git.