Git Product home page Git Product logo

Comments (8)

lucasscarduelli avatar lucasscarduelli commented on June 4, 2024

Pull request #23

from cache-tort-git.

adaptun avatar adaptun commented on June 4, 2024

Can you please provide output of
zwrite ^Git from namespace where error happens

from cache-tort-git.

lucasscarduelli avatar lucasscarduelli commented on June 4, 2024

This file really not exists, the problem is the "OnBeforeLoad" from %SourceControl.Git is executed before creating the file also.

from cache-tort-git.

adaptun avatar adaptun commented on June 4, 2024

I don't think that this is the problem OnBeforeLoad should not throw error if there are no external file.

from cache-tort-git.

lucasscarduelli avatar lucasscarduelli commented on June 4, 2024

Yes, i agree. The problem happens when the " LoadIfOutdated " method tries to load the file and it does not exist. I think we can fix this by validating method if the file actually exists.

from cache-tort-git.

lucasscarduelli avatar lucasscarduelli commented on June 4, 2024

Ok, it's resolved but my last commit resolved a potencial bug too.
You can merge?

from cache-tort-git.

adaptun avatar adaptun commented on June 4, 2024

I think we don't need to check that file exists in LoadIfOutdated because IsRoutineOutdated should return false if there is no corresponding file on disk, so there is no need to merge.

from cache-tort-git.

lucasscarduelli avatar lucasscarduelli commented on June 4, 2024

In my opinion the most correct is to validate if the file or routine exists and don't set a fictious date to this.
So for me the responsibilities of validations are confused , if we think of quality as correct code would be to separate these validations .

from cache-tort-git.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.