Comments (6)
deepakkumar96
commented on July 3, 2024
1
Ok, I'm changing the 'file not found' message to include path too!
…On Thu, Jul 18, 2019 at 12:41 PM Julie Sullivan ***@***.***> wrote:
We want to give the user enough information to fix the problem.
This goes for all error messages but specifically file not found. Update
this error message to include the path that was tried.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#19?email_source=notifications&email_token=AED7EHBETUK4Z44MXWX6ZUDQAAJTXA5CNFSM4IEXT5E2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G75T46A>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AED7EHH7F5H7NEDOJSORWFDQAAJTXANCNFSM4IEXT5EQ>
.
from biovalidator.
julie-sullivan
commented on July 3, 2024
Just thinking out loud here. Do we want to throw an exception there?
Another option would be to catch that exception and return the correct error message.
We don't want fatal errors in our library, I don't think?
from biovalidator.
deepakkumar96
commented on July 3, 2024
I thought if the library is not able to find the file, then its not a
validation error, and that is why I throw an error!
…On Thu, Jul 18, 2019 at 12:47 PM Julie Sullivan ***@***.***> wrote:
Just thinking out loud here. Do we want to throw an exception there?
Another option would be to catch that exception and return the correct
error message.
We don't want fatal errors in our library, I don't think?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#19?email_source=notifications&email_token=AED7EHG3JFMM5M42RDW4YH3QAAKHTA5CNFSM4IEXT5E2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2HR6RY#issuecomment-512696135>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AED7EHG5TNIL7JU7A6B6GU3QAAKHTANCNFSM4IEXT5EQ>
.
from biovalidator.
deepakkumar96
commented on July 3, 2024
Sorry, which exception you were referring to? FileNotFoundException or
something else?
On Thu, Jul 18, 2019 at 12:52 PM Deepak Kumar <[email protected]>
wrote:
… I thought if the library is not able to find the file, then its not a
validation error, and that is why I throw an error!
On Thu, Jul 18, 2019 at 12:47 PM Julie Sullivan ***@***.***>
wrote:
> Just thinking out loud here. Do we want to throw an exception there?
>
> Another option would be to catch that exception and return the correct
> error message.
>
> We don't want fatal errors in our library, I don't think?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#19?email_source=notifications&email_token=AED7EHG3JFMM5M42RDW4YH3QAAKHTA5CNFSM4IEXT5E2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2HR6RY#issuecomment-512696135>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AED7EHG5TNIL7JU7A6B6GU3QAAKHTANCNFSM4IEXT5EQ>
> .
>
from biovalidator.
julie-sullivan
commented on July 3, 2024
There was an exception for other things as well. For having the wrong file type, for example.
I can add a bunch of catch statements when using your library, but I am going to be doing the same thing for each -- returning the error message to the user.
from biovalidator.
julie-sullivan
commented on July 3, 2024
this is done, the file path is given in the error message.
from biovalidator.
Related Issues (14)
- biovalidator version ? HOT 1
- File format - need a standard HOT 1
- Suggestion - a single error message HOT 1
- Error message suppression strategy? HOT 4
- Publish javadoc HOT 2
- Make rules more visible. HOT 2
- GFF3: Should we be case-sensitive HOT 2
- Filetype is not required -- better error message, or guess the filetype. HOT 1
- Only want error messages, don't want exceptions HOT 2
- Performance benchmarking
- gff validator validatest the attributes columns contains key but not values
- add to JCenter HOT 1
- extractSequenceIdFromHeader() could be more readable HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from biovalidator.