Git Product home page Git Product logo

Comments (2)

YodaEmbedding avatar YodaEmbedding commented on August 22, 2024

Thanks for the report.

I could add a version check for torch<2.0:

from packaging.version import Version

class CheckerboardLatentCodec(LatentCodec):
    def _y_ctx_zero(self, y: Tensor) -> Tensor:
        if Version(torch.__version__) < Version("2.0.0"):
            return self._mask(self.context_prediction(y).detach(), "all")
        return y.new_zeros(self.context_prediction(y.to("meta")).shape)

...but perhaps simpler is just to revert:

class CheckerboardLatentCodec(LatentCodec):
    def _y_ctx_zero(self, y: Tensor) -> Tensor:
        return self._mask(self.context_prediction(y).detach(), "all")

from compressai.

lucasrelic99 avatar lucasrelic99 commented on August 22, 2024

To be fair I don't actually know which is the earliest torch version that supports meta device tensors as I couldn't find any solid information.

Although I think the simpler fix is probably good enough. On my machine with a 14900K and a 3090 and an (unreasonably large) context size of (16, 192, 512, 512) it takes 0.06ms to execute that line on GPU. It does take about 4 seconds on CPU, but with a more reasonable context size of (16, 192, 32, 32) it takes roughly 80ms on CPU.

from compressai.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.