Comments (6)
Everything should be completed as you requested. I ran the tests and get the same results pre vs post restructuring, so I'm hoping I put it back together correctly. I'm going to sleep on it before submitting the pull request, but its current state is on my fork https://github.com/nlundby/EssentialCSharp/tree/v7.0
from essentialcsharp.
Wow Neal... that was fast. Thanks!
Can you please identify what tests are failing for you. On Windows, all the tests are passing for me. Thanks!
from essentialcsharp.
Pull request submitted. These two tests were failing for me on both Mac and Windows:
Listing15.14.Tests.cs(31,57): error CS1501: No overload for method 'ExpectLike' takes 3 arguments [./EssentialCSharp/src/Chapter15.Tests/Chapter15.Tests.csproj]
Listing14.12.ProjectionWithSystem.Linq.Enumerable.Select.Tests.cs(40,36): error CS1501: No overload for method 'IsLike' takes 2 arguments [./src/Chapter14.Tests/Chapter14.Tests.csproj]
A fix was submitted in my pull request.
from essentialcsharp.
Is it possible that you haven't updated your sub modules so you have and old version of test too,s by chance? (Or, alternatively, I didn't update the sub module pointer to point to the most recent TestTools perhaps?)
from essentialcsharp.
Bingo! All is well. Yes, I believe the submodule pointer does not point to the most recent TestTools. I added some steps to the Readme to ensure the latest are downloaded. Unfortunately this did not resolve the mac(and now verified linux) test fail on listing08.16.
My 15.14 and 14.12 changes have been retracted in the pull request.
from essentialcsharp.
From the comments and looking at the current state of the code it sounds like a PR was made against this and these changes are live.
from essentialcsharp.
Related Issues (20)
- Investigate why build failure is occurring only on mac HOT 2
- Run tests with different locales HOT 2
- TFM moved from Directory.Build.props to each csproj file
- Mitigating dotnet 6 failure on ubuntu HOT 1
- To go to new lang version of the book...
- Revisit 20.7 to make work properly HOT 1
- Delete ../src/Chapter01/Directory.Build.props HOT 1
- Update Directory.Build.props to use C# 11.0 for LangVersion element (once released) HOT 1
- Rename v9.0 Branch? HOT 2
- Testing 10.23 doesn't complete reliably especially
- Update Readme File
- Find an alternate location (or delete) Publishing a Stand-Alone Executable - Advanced Block
- Switch the CompileError class in CompilerAssert.cs to be a record HOT 1
- Switch expected strings from string literals to RAW literals in unit tests HOT 1
- Add support for method filtering to ...\src\Shared\Tests\CompilerAssert.cs HOT 1
- Write Unit Tests for Table.03.01 HOT 1
- Move Microsoft.VisualStudio.TestTools.UnitTesting using statement into Chapter.Tests.prop
- Create tests for Table03.01
- Create Table04.01.ControlFlowStatements.cs and accompanying tests
- Write test for Listing04.27.OutOfScope.cs using CompilerAssert.cs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from essentialcsharp.