Git Product home page Git Product logo

Comments (6)

nlundby avatar nlundby commented on May 26, 2024

Everything should be completed as you requested. I ran the tests and get the same results pre vs post restructuring, so I'm hoping I put it back together correctly. I'm going to sleep on it before submitting the pull request, but its current state is on my fork https://github.com/nlundby/EssentialCSharp/tree/v7.0

from essentialcsharp.

MarkMichaelis avatar MarkMichaelis commented on May 26, 2024

Wow Neal... that was fast. Thanks!

Can you please identify what tests are failing for you. On Windows, all the tests are passing for me. Thanks!

from essentialcsharp.

nlundby avatar nlundby commented on May 26, 2024

Pull request submitted. These two tests were failing for me on both Mac and Windows:

Listing15.14.Tests.cs(31,57): error CS1501: No overload for method 'ExpectLike' takes 3 arguments [./EssentialCSharp/src/Chapter15.Tests/Chapter15.Tests.csproj]
Listing14.12.ProjectionWithSystem.Linq.Enumerable.Select.Tests.cs(40,36): error CS1501: No overload for method 'IsLike' takes 2 arguments [./src/Chapter14.Tests/Chapter14.Tests.csproj]

A fix was submitted in my pull request.

from essentialcsharp.

MarkMichaelis avatar MarkMichaelis commented on May 26, 2024

Is it possible that you haven't updated your sub modules so you have and old version of test too,s by chance? (Or, alternatively, I didn't update the sub module pointer to point to the most recent TestTools perhaps?)

from essentialcsharp.

nlundby avatar nlundby commented on May 26, 2024

Bingo! All is well. Yes, I believe the submodule pointer does not point to the most recent TestTools. I added some steps to the Readme to ensure the latest are downloaded. Unfortunately this did not resolve the mac(and now verified linux) test fail on listing08.16.

My 15.14 and 14.12 changes have been retracted in the pull request.

from essentialcsharp.

COsborn2 avatar COsborn2 commented on May 26, 2024

From the comments and looking at the current state of the code it sounds like a PR was made against this and these changes are live.

from essentialcsharp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.