Git Product home page Git Product logo

Comments (15)

bader avatar bader commented on May 8, 2024 4

A little bit of statistics before 2023 year starts.
Here is the chart with the code difference between sycl (DPC++) branch and main (llvm.org):
DPCPPvsLLORG

The chart starts 109794 added and 182 deleted lines of code on Jan 29 of 2019 (669 modified files) and ends with 767401 added and 10563 deleted lines of code on Dec 29 of 2022 (5470 modified files).

I also build a chart with git diff --diff-filter=M, which I think should demonstrate the track of changes in community files (i.e. excluding new files added to the sycl branch).
ModifiedLLVMFiles

The chart starts 1416 added and 182 deleted lines of code on Jan 29 of 2019 (82 modified files) and ends with 40954 added and 6533 deleted lines of code on Dec 29 of 2022 (817 modified files).

The trend is clear: the difference is growing between DPC++ source code base and LLVM community code base.

from llvm.

airlied avatar airlied commented on May 8, 2024 3

ping, is there still a plan to upstream SYCL to llvm?

from llvm.

bader avatar bader commented on May 8, 2024 2

Yes, we still plan to upstream SYCL llvm. Unfortunately, the progress is slower than we would like to see, so any help is very welcome.

I'm glad to know that there is an interest in having SYCL support in upstream llvm.

from llvm.

bader avatar bader commented on May 8, 2024

Also created a wiki page with "upstream status" for SYCL patches: https://github.com/intel/llvm/wiki/SYCL-patches-upstream-status.

from llvm.

wangliwei-intel avatar wangliwei-intel commented on May 8, 2024

Hi, @bader
Codeplaysoftware is driving upstreaming their SYCL back-end for tensor in Eigen:
https://bitbucket.org/codeplaysoftware/eigen/src/default/
As far as you know, Is anyone trying to build it with Intel/llvm/sycl?
I'm not sure this is worth a new issue, I can't find a proper issue relevant either, so I just ask here.
Thanks.

from llvm.

bader avatar bader commented on May 8, 2024

@wangliwei-intel, I'm not aware of any progress in this direction.

from llvm.

wangliwei-intel avatar wangliwei-intel commented on May 8, 2024

Hi, @bader
Then I'll give a try.
Thanks.

from llvm.

asudarsa avatar asudarsa commented on May 8, 2024

hi @bader

Based on some of my 'very' preliminary analysis, it seems like we have considerable difference in the test cases available in DPC++ source code and LLVM community code. I can take a closer look if that is something of use.

Thanks

from llvm.

keryell avatar keryell commented on May 8, 2024

A little bit of statistics before 2023 year starts

Quite interesting. Could you combine the 2 graphics in one and put a log scale on vertical axis? Or send the scripts so I can run them myself and experiment with the graphics. :-)

from llvm.

keryell avatar keryell commented on May 8, 2024

I'm glad to know that there is an interest in having SYCL support in upstream llvm.

Of course there is! :-)
But considering that Khronos has not finished to produce a Conformance Test Suite for SYCL 2020 yet, there is no official full SYCL 2020 implementation yet and it makes sense to direct the work force mostly on polishing the current SYCL 2020 and preparing SYCL Next rather than up-streaming everything today as is, since it might change a little bit with a better big picture coming from the feedbacks learned with the complete SYCL 2020 implementations.

from llvm.

bader avatar bader commented on May 8, 2024

A little bit of statistics before 2023 year starts

Quite interesting. Could you combine the 2 graphics in one and put a log scale on vertical axis? Or send the scripts so I can run them myself and experiment with the graphics. :-)

Here is the bash command I used to get the data:

for D in {0..47}
do
  x=`git log --first-parent --pretty=%H origin/sycl -1 --before="$D months"`
  echo $D , `git diff --diff-filter=M --shortstat -l 0 origin/main...$x`, `git log --pretty='format:%h %ad' -1 $x`

I put the results to the Excel and build these charts there.

To get the data for the first chart, just remove --diff-filter=M flag.

NOTE: there is one outlier in the data. Usually we merge llvm.org patches to the sycl branch with git merge command, but one time we accidentally used git rebase. Somewhere around this time these commands return incorrect values. I used interpolation to make lines continuous.

from llvm.

bader avatar bader commented on May 8, 2024

I'm glad to know that there is an interest in having SYCL support in upstream llvm.

Of course there is! :-)

@keryell, you are welcome to join sync meetings if interested (details).

But considering that Khronos has not finished to produce a Conformance Test Suite for SYCL 2020 yet, there is no official full SYCL 2020 implementation yet and it makes sense to direct the work force mostly on polishing the current SYCL 2020 and preparing SYCL Next rather than up-streaming everything today as is, since it might change a little bit with a better big picture coming from the feedbacks learned with the complete SYCL 2020 implementations.

That's basically what's happening right now. In addition to enabling SYCL 2020 features, we are also discussing other improvements which can make the upstream process easier.

from llvm.

keryell avatar keryell commented on May 8, 2024

@keryell, you are welcome to join sync meetings if interested (details).

@bader Oh thanks. I missed the fact that this meeting started again.

from llvm.

keryell avatar keryell commented on May 8, 2024

Here is the bash command I used to get the data:

@bader thanks, I will try.

from llvm.

nullr0ute avatar nullr0ute commented on May 8, 2024

Yes, we still plan to upstream SYCL llvm. Unfortunately, the progress is slower than we would like to see, so any help is very welcome.

I'm glad to know that there is an interest in having SYCL support in upstream llvm.

What's the latest on this initiative, it's hard to know what, if any of the major points above, have been achieved or any links to bugs for the components or requests so hard to know where to assist/look.

from llvm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.