Compile ittapi-rs' C code on Windows about ittapi HOT 7 CLOSED

The only information I get is that it returns exit code 2, fwiw.

from ittapi.

Also credits to @Jake-Shadle for noticing that the OS cfg! might be busted in cross-compilation environments: we should try to use https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-build-scripts instead.

from ittapi.

I think I understand a bit more what's going on, after using cargo build -vv the error's details are printed out to stderr, and it complains about the C file not being found. That's because on Windows, the symbolic links don't seem to work, so the src and include paths can't be read. On the other hand, if we use just relative paths to ../src and ../include, that compiles fine on both Windows and Linux.

However, with that relative path, we can't package the crate anymore, because it references files that are external to the source directory. With the symbolic links solution, cargo package seems to copy the content of the symlinked files, which seems sufficient. So that means that the current solution would work if we only packaged from a Linux install, and then the packaged crate would compile Just Fine on Linux & Windows.

It's not ideal though, because it makes local development and testing of ittapi-rs on Windows painful. Wonder if there would be other ways that work on all platforms, and allow testing/publishing from every platform.

from ittapi.

A small reorganization of the code could maybe work: the interesting C source files would be moved to the Rust directory, and the C code itself would contain symlinks to those C files. Will try that.

from ittapi.

@bnjbvr, with #41 merged and #44 in the queue, this issue should be on the way to being closed. I think the remaining part may be to (1) do some more testing in a Windows environment (I have done this but I would like a double-check if possible), and (2) publish a new version of the crate--perhaps v0.2.0? (cc: @jlb6740)

from ittapi.

Could confirm it worked with the canonical doc example in wasmtime on Windows 👍

from ittapi.

Closing, seee latest 0.2.0 release of the Rust crate.

from ittapi.