Code review about intelseapi HOT 5 OPEN

No, it wasn't helpful. And I wonder why spending your time doing that? :)

'a "perfect" team, that followed all these good design principles and practices' would be code oriented more than business oriented with all the consequences. Feature quality is incomparably much more valuable. Personally I wouldn't suggest anyone to become part of code oriented team. Everything is measured by result. And I consider as good code the one that has created a good feature, not the one that just looks shining.

Do you advertise an automatic code brushing solution or want to help making code better? I am for it. :) I don't mind to have shining code after all, if it doesn't steal feature development time.

Or you JUST pointing out that the code is not perfect, because you could write better? :)

from intelseapi.

No, it wasn't helpful.
It is pity.

And I wonder why spending your time doing that? :)
Just for fun, like watching movies :) and to see what happens outside my own company, where guys (at least my team) are able to produce high quality code, while being more(!) productive in terms of being business oriented.

I consider as good code the one that has created a good feature, not the one that just looks shining.
I believe it is a true statement - the code that produces a good feature is good.
But I do also believe that you should also be confident enough that you do not break another features that exist when you are adding new.
I cannot believe you are confident when you add a really large feature that needs lot of existing code to be changed.
You should have very plain code with a very small cyclomatic complexity metric (so you have 1-2 scenarios to test manually) or you should have plenty of automatic tests (you have no, as I see: https://github.com/01org/IntelSEAPI/search?p=1&q=test&type=&utf8=%E2%9C%93).
You should not feel like adding a new feature is like adding it from the scratch (you should reuse a lot of you existing business model, you should feel like the feature is already there and you need just enable it). The code (that code oriented command produces) helps adding more and cooler features to the product.

Do you advertise an automatic code brushing solution
I do really want to run some C++/Python code analysis tools to take a look at what they say - just for fun (I see you use these languages mostly (Python 42.4%,C 28.6%, C++ 16.9%, ...).
And I think there should exist some automated (or even automatic) C++/Python linters that can do smth for you.
Also as you use C++/Python I think smth similar to ReSharper C++ or PyCharm should help you producing more clean code without thinking about your "spent" time:
https://www.jetbrains.com/resharper/eap/
https://www.jetbrains.com/pycharm/

I'll be back (but with some code metrics of your solution) :)

from intelseapi.

More to add.
DDD - domain driven design - the approach used by many "serious" companies as a way to streamline their development. The idea is to focus on business but reflect it in the code. It gives both of 2 worlds - good and clean code due to its alignment with features business want and fast emission of new features (what business expects) due to the same reason :)

from intelseapi.

Well, great! I see that you are very knowledgeable in code quality area. And I see that you really want to help, not just to ridicule. And since this is open-source project, you can make your contribution! Next time you have a half of hour to spend around this code, please improve a function or two. Please don't forget to run the tests, they are in "test_*.sh/bat"

from intelseapi.

Default pylint config shows the following:
Your code has been rated at 5.86/10

pylint_results.txt

from intelseapi.