Git Product home page Git Product logo

Comments (13)

ttung avatar ttung commented on June 19, 2024

What happens when you combine the two?

from ig-json-parser.

larten avatar larten commented on June 19, 2024

Butterknife doesn't working.

from ig-json-parser.

TommyVisic avatar TommyVisic commented on June 19, 2024

I'm using both together without a problem. I don't believe I had to make any changes either. Have you confirmed that IG JSON Parser is working properly on its own?

from ig-json-parser.

larten avatar larten commented on June 19, 2024

My json models are in the android app module and if gradle task for ig-json-parser is uncommented, than it's generate correctly the models and I get NullPointerException for every view, but if I comment this, than work.

from ig-json-parser.

TommyVisic avatar TommyVisic commented on June 19, 2024

I think you need to put IG parser in its own module. Now that I think about it, I did run into an issue w/ the java gradle plugin causing some kind of incompatibility when merge with the main build.gradle. I know the IG folks use the parser in this way too as not to expose the models' members with default visibility. Here's how we have it set up.

screen shot 2015-02-09 at 10 40 54 am

from ig-json-parser.

larten avatar larten commented on June 19, 2024

Okay, maybe it will be good, but now my classes don't see generated files in model modul.
Could you share this part of your gradle script?

from ig-json-parser.

TommyVisic avatar TommyVisic commented on June 19, 2024

settings.gradle

include ':tastemade'
include ':tastemade:jsonModels'

app module build.gradle

apply plugin: 'android'

android {
    ...
}

dependencies {
    compile 'com.jakewharton:butterknife:5.1.2'
    compile project(':tastemade:jsonModels')
    ...
}

jsonModels module build.gradle

apply plugin: 'java'

ext {
    generatedSourcesDir = file("gen-src/main/java")
}

sourceSets {
    main {
        java {
            srcDir 'src/main/java'
        }
    }
    gensrc {
        java {
            srcDir 'gen-src/main/java'
        }
    }
}

compileJava {
    doFirst {
        // Directory should exists before compilation started.
        generatedSourcesDir.mkdirs()
    }
    options.compilerArgs += [
            '-processor',
            'com.instagram.common.json.annotation.processor.JsonAnnotationProcessor',
            '-s',
            generatedSourcesDir

    ]

    sourceCompatibility = JavaVersion.VERSION_1_7
    targetCompatibility = JavaVersion.VERSION_1_7
}

dependencies {
    compile 'com.instagram:ig-json-parser-processor:0.0.3'
}

from ig-json-parser.

szoszig avatar szoszig commented on June 19, 2024

Hello,
I have the same problem.
I did everything you wrote, but my app modul can't see the properly generated helper methods, just the models I wrote.
Do you have any advice?

thx,
Szöszi

from ig-json-parser.

larten avatar larten commented on June 19, 2024

I have same problem :(

from ig-json-parser.

ttung avatar ttung commented on June 19, 2024

Sorry for the late response. Generally, we do indeed put the models in separate modules to avoid inadvertent access to package-privacy fields. However, there should be nothing that requires that behavior.

Unsure what's going on with the interaction with Butterknife, I will try it out when I get a chance.

In the meanwhile, I pushed a change so that the jar file tells the compiler how to invoke the annotation processor. Maybe that will help the issue? LMK!

from ig-json-parser.

ttung avatar ttung commented on June 19, 2024

Specifically, 86f29b5

from ig-json-parser.

szoszig avatar szoszig commented on June 19, 2024

Sorry, but it's the same.

from ig-json-parser.

 avatar commented on June 19, 2024

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

from ig-json-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.