Comments (3)
Yeah looks like no_string_type_annotation
guards against typing_extension.Literal
but not typing.Literal
:
But also the rule should probably not crash when parse_expression
raises an exception
from fixit.
The relevant part of that traceback is
File "/home/pierre/pylint/venv/lib/python3.10/site-packages/fixit/rules/no_string_type_annotation.py", line 303, in visit_SimpleString
replacement=cst.parse_expression(node.evaluated_value),
I'm guessing (based on which types have the string "class
in them) that this is from https://github.com/pylint-dev/pylint/blob/fc97635b9515b650be2ce0e75a36e47a45094ccf/pylint/checkers/base/docstring_checker.py#L154
Don't know if this is a bug in no_string_type_annotation
or not, but HTH
from fixit.
Fixit suggest to remove the quote around strings in typing.Litteral
in another check (this is definitely a bug as the litteral string is not defined). Maybe a wrong assumption is being made here too ?
from fixit.
Related Issues (20)
- A way to show silenced errors
- `lint-fixme` comments not respected HOT 3
- fixit upgrade makes incomplete fix, second run results in metadata error HOT 1
- Support Glob Patterns in `[[tool.fixit.overrides]]` HOT 2
- `fixit fix` exits with `0` even if there were errors HOT 2
- Support multiple paths in overrides block
- QUESTION: Can fixit be used for languages other than Python? HOT 1
- Use formal specification for license field in pyproject.toml HOT 1
- Add options to ignore directories HOT 1
- Autofix does not work with "black" formatter if black formatter changes nothing
- add slots=True to the dataclass replacing named tuples.
- Problem configuring custom rules in pre-commit.
- lsp: tracking issue for code actions features
- Access to rule options
- Allow dicts and lists in rule options
- Fixit can be incredibly slow. Are there any recommendations available for profiling checks? HOT 8
- Fixit is incredibly slow with many files.
- Is there a way to detect from within a LintRule if it's being run under test? HOT 1
- ChatBox _ UI _ The ChatBox UI has incorrect alignment, and the last reels were not refreshed. HOT 1
- False negatives with Python3.13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fixit.