Git Product home page Git Product logo

Comments (7)

jimmylai avatar jimmylai commented on August 18, 2024

Having a single CLI command is a good idea. We already do that for LibCST.
To keep it simple, the command should be named as fixit
and users can provide different sub-command, e.g.

  • fixit run_rules
  • fixit apply_fix

Why do you need both launch_cli and main rather than just a main?
Then the console-script can point to cli.main:main.

from fixit.

jimmylai avatar jimmylai commented on August 18, 2024

Your PRs are very welcome!

from fixit.

acharles7 avatar acharles7 commented on August 18, 2024

Your PRs are very welcome!

Thank you, Should I do in separate folder? i.e fixit/cli2/

from fixit.

acharles7 avatar acharles7 commented on August 18, 2024

Having a single CLI command is a good idea. We already do that for LibCST.
To keep it simple, the command should be named as fixit
and users can provide different sub-command, e.g.

  • fixit run_rules
  • fixit apply_fix

Why do you need both launch_cli and main rather than just a main?
Then the console-script can point to cli.main:main.

Yes, I can do that too. But, I want to parse arguments separately and TBH more modular. So this is one way I can think of.
Let me know if you have any other ideas.

from fixit.

acharles7 avatar acharles7 commented on August 18, 2024

Your PRs are very welcome!

Thank you, Should I do in separate folder? i.e fixit/cli2/

How should I make PRs? because I need to change some existing files in each small PR for each sub-command, which might cause conflict.

from fixit.

jimmylai avatar jimmylai commented on August 18, 2024

Your PRs are very welcome!

Thank you, Should I do in separate folder? i.e fixit/cli2/

How should I make PRs? because I need to change some existing files in each small PR for each sub-command, which might cause conflict.

I would just add a cli/main.py and modify other files to add them to the new CLI while keeping their existing CLI works for backward compatibility.
One or multiple PRs are both fine to me.

from fixit.

acharles7 avatar acharles7 commented on August 18, 2024

Thank you.

from fixit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.