PHPCBF Breaks Syntax about php-coding-standards HOT 7 CLOSED

I'm closing this. We're receiving bugfixes release sfrom upstream PHPCS so we should get the fix if they do it. If the fix will be done in a major/minor, we will get that when we'll update... I think we need to keep PHPCS updated anyway.

from php-coding-standards.

This only happens when there already was an encoding declaration on the same line as the opening PHP tag. See c10f795 (#10).

from php-coding-standards.

Looks like it's one of PSR12.Files.OpenTag.NotAlone or PSR12.Files.FileHeader.SpacingAfterBlock that's doing this.

from php-coding-standards.

It was PSR12.Files.OpenTag.NotAlone. Excluding this sniff results in the tag being alone, and a blank line between it and the comment.

from php-coding-standards.

This looks like a bug in the upstream PSR12 rule.

We could exclude the rule in our standard, but the rule itself is fine. The problem is the "fix" part that is problematic. Maybe we should send a PR to PHPCS...

from php-coding-standards.

Yep, looks like a problem in PSR12. Sounds good!

from php-coding-standards.

This is still present, FYI.

from php-coding-standards.