Git Product home page Git Product logo

Comments (3)

gmazzap avatar gmazzap commented on June 2, 2024 1

Yes, we need to more forward, and this must be done before we gan get to v1 of the standards.

The change of WPCS will requires changes to code comments like phpcs:disable because WPCS 1.0+ chnaged the version of their sniffs.

So even if in theory we could do breaking changes in 0.* version without breaking semver, I really would like to avoid to switch to WPCS 1.* on the 0.* series of Inpsyde styles.

from php-coding-standards.

websupporter avatar websupporter commented on June 2, 2024

Another reason to move is now PHP7.4

With PHP 7.4 the checks can't be properly executed because $last can be null here, which results in those error messages:

 1 | ERROR | An error occurred during processing; checking has been
   |       | aborted. The error message was: Trying to access array
   |       | offset on value of type null in
   |       | /tmp/vendor/wp-coding-standards/wpcs/WordPress/Sniff.php
   |       | on line 1375 (Internal.Exception)

If we would require ^2.2.1 this problem would be solved, see here.

from php-coding-standards.

gmazzap avatar gmazzap commented on June 2, 2024

Done in 52edc0b

from php-coding-standards.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.