Comments (3)
Yes, we need to more forward, and this must be done before we gan get to v1 of the standards.
The change of WPCS will requires changes to code comments like phpcs:disable
because WPCS 1.0+ chnaged the version of their sniffs.
So even if in theory we could do breaking changes in 0.* version without breaking semver, I really would like to avoid to switch to WPCS 1.* on the 0.* series of Inpsyde styles.
from php-coding-standards.
Another reason to move is now PHP7.4
With PHP 7.4 the checks can't be properly executed because $last
can be null
here, which results in those error messages:
1 | ERROR | An error occurred during processing; checking has been
| | aborted. The error message was: Trying to access array
| | offset on value of type null in
| | /tmp/vendor/wp-coding-standards/wpcs/WordPress/Sniff.php
| | on line 1375 (Internal.Exception)
If we would require ^2.2.1
this problem would be solved, see here.
from php-coding-standards.
Done in 52edc0b
from php-coding-standards.
Related Issues (20)
- Closure Turned Static Breaks Code HOT 1
- Warning or Error when PHP_INT_MAX or PHP_INT_MIN is used in add_action or add_filter HOT 3
- [Feature Request]: Add check for Emacs UTF-8 file header HOT 1
- [Question] When using phpcbf there is a bug for the rule that leaves the first line with opening php tag HOT 3
- Review Squiz.Scope.MethodScope.Missing rule in interfaces and PhpAnnotator conflict HOT 1
- [Feature Request]: Add check for whitespace after type casting HOT 3
- [Feature Request]: Bump squizlabs/php_codesniffer HOT 1
- [Feature Request]: Add a rule against unused imports HOT 2
- [Feature Request]: Add rules for arrow functions
- [Feature Request]: Add more tests for array spread operator
- [Feature Request]: Add a sniff for unused services HOT 2
- [Feature Request]: Update dependencies to be compatible with PHP 8
- [Feature Request]: Get rid of Neutron PHP Standard
- [Feature Request]: Configure Dependabot HOT 2
- [Feature Request]: Evaluate which "Slevomat" coding standard sniffs to use HOT 2
- [Feature Request]: Embrace PHPCSUtils
- [Upgrade]: Modernize existing sniffs
- [Feature Request]: Add a sniff to enforce property type HOT 2
- [Feature Request]: Replace cyclomatic complexity with Cognitive Complexity
- Having trouble finding a working composer.json configuration HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from php-coding-standards.