Git Product home page Git Product logo

Comments (4)

inlife avatar inlife commented on May 28, 2024

Hey @estevopaz

I like that you suggested the node-id parameter. We could extend this idea even further, outside of the scope of just IP addresses and a set of manual custom identifiers.

Ideally, if we would wish to identify our worker, we would set up an "--id" or a "--name" even (and I would actually go for the latter). And then that name would show up at the job definition on the server. It would also make sense to generate a name for cases, when it was not set and print it out in the console when the worker starts.
One question I do not have an answer to, is whether the name should be persisted after it was once generated, and if so, how to treat cases with multiple workers per single machine and their name persistence.

The IP should also be present and used, but most likely, we need to combine the name and IP into a single object on the server side. And, if possible, to get rid of duplicated keys "creator", "jobCreator", etc.

How do you think, would a structure like this work?

"updatedAt":"2023-05-16T14:00:56.321Z",
"createdAt":"2023-05-16T13:56:11.007Z",

"creator": {"name":"worker1", "host": "::ffff:127.0.0.1"},
"executor": {"name":"worker1", "host": "::ffff:127.0.0.1"},

"startedAt":"2023-05-16T13:56:12.652Z",
"finishedAt":"2023-05-16T14:00:57.220Z",

"renderProgress":97,
"error":null,
"errorAt":null,

Folks, @Thiago-Dantas @mohali-id, it would also be interesting to get your input on this since you both worked on this feature!

Thanks 🎉

from nexrender.

estevopaz avatar estevopaz commented on May 28, 2024

That would be a perfect solution, thanks.
About the persistence, IMHO it hasn't a good balance work-profit, but just my opinion.

Thanks Vladyslav.

from nexrender.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.