Git Product home page Git Product logo

Comments (7)

alexellis avatar alexellis commented on May 27, 2024 1

For the first attempt you should do nothing and assume that is in the path. At later time we can invoke the existing code which performs a download, if we are unable to locate the binary.

from inletsctl.

adamjohnson01 avatar adamjohnson01 commented on May 27, 2024 1

@alexellis, you are right I should have commented instead of removing it. I just didn't want to create confusion about who was doing the work.

@utsavanand2, sure I am happy to help out however I can. :)

from inletsctl.

utsavanand2 avatar utsavanand2 commented on May 27, 2024

@alexellis I would love to know what do you think the right approach would be?
Including inlets from inletsctl as a binary or including the package in the vendor dir?

from inletsctl.

alexellis avatar alexellis commented on May 27, 2024

@adamjohnson01 I think I missed your comment here?

from inletsctl.

adamjohnson01 avatar adamjohnson01 commented on May 27, 2024

@alexellis, I said that I would work on it but then I saw @utsavanand2 said in slack that he was working on it so I removed it.

from inletsctl.

utsavanand2 avatar utsavanand2 commented on May 27, 2024

@adamjohnson01 I would love your feedback on it! Maybe we can collab together? I'll push some changes tonight. We'll see how it works.

@alexellis I've created a check which makes sure inlets or inlets-pro is in /usr/local/bin/

from inletsctl.

alexellis avatar alexellis commented on May 27, 2024

It might be worth keeping all messages rather than deleting any so that we don't clash or duplicate work. Async communication is hard.

@utsavanand2 for the first version, there's probably no need to check that the tool exists at all. Let's keep it simple and get it shipped quickly.

from inletsctl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.