Generated output command for Delete results in error for gce provider about inletsctl HOT 17 CLOSED

0.4.1 seems to work 👍

from inletsctl.

@adamjohnson01 @utsavanand2 please can you take a look into this?

from inletsctl.

@alexellis, @burtonr and @utsavanand2 I know what the issue is and will raise a PR to fix it. The issue is here

I introduced this when I added the delete by IP functionality, the problem is that the project-id from the instance name string is not being used.

Apologies, I did not test the normal delete functionality when I added the delete by ip functionality.

from inletsctl.

I also found this with a DO exit node, downgrading to 0.3.9 release worked.

Looks like a regression

from inletsctl.

I can't reproduce this, it might have been fixed in 0.4.1, please can you guys re-test? https://github.com/inlets/inletsctl/releases/tag/0.4.1

from inletsctl.

Updated to 0.4.1. The error in the original description is gone, but now there is a different error:

gcp is the .json file that contains the credentials

$ inletsctl delete --provider gce --id "determined-curran1|us-central1-a|burtonr"
Using provider: gce
give a value for --access-token-file or --access-token

$ inletsctl delete --provider gce --id "determined-curran1|us-central1-a|burtonr" -f gcp
Using provider: gce
Deleting host: determined-curran1|us-central1-a|burtonr from gce
could not delete the GCE instance: googleapi: got HTTP response code 404 with body: Not Found

from inletsctl.

I've personally tested Packet and DO recently and would suggest using those. You can also set up your own VMs the old fashioned way.

Let's see if @utsavanand2 can help with this issue, who wrote the code for GCE

from inletsctl.

@burtonr I'll take a look at this. I'm having issues with GCE, particularly with the firewall rules with Stackdriver logs stating that I do not have enough permissions. I would be really grateful if I can get some suggestions from you, since I guess you have a GCP account 😄

from inletsctl.

Hey @utsavanand2 Thanks for helping out. Yes, I use GCP for a lot of my personal projects.
For inletsctl, the service account, or credentials that you pass it, the account must have at least:

• compute.firewalls.create
  • There is no specific "compute.firewalls" permissions that I could find though, so I set it to Admin
• serviceaccount user

I have an inlets service account that's set up as "compute admin" and "iam.serviceAccountUser". That worked for setting it all up, but having trouble getting the delete command to work. Compute Admin has enough permission to do everything. I'll go back and make that more specific once I get it all up and running properly

from inletsctl.

@burtonr If you see here, I am using the compute.Admin role, which has network admin rights too and the serviceaccount user role. But inlets-op seems to have trouble with creating the firewall rules for the inlets control port. Though this is a different topic but can be related, considering the merged PR was working completely fine for a couple of weeks, and suddenly broke. I'm afraid if this is another example of that issue.
I have read the godocs for the google cloud sdk and apparently it is created automatically with gRPC. I don't know if this a result of any inconsistent request formats that might have been updated in the upstream SDK but not in the vendor, but I'm not sure.
Thanks a lot for your input though.
I'll check and see if I can fix it by tomorrow

from inletsctl.

I see that the import for inlets is "google.golang.org/api/compute/v1"

Looking at the source repo, I see this section in the first paragraph of the readme:

If you're working with Google Cloud Platform APIs such as Datastore or Pub/Sub, consider using the Cloud Client Libraries for Go instead. These are the new and idiomatic Go libraries targeted specifically at Google Cloud Platform Services.

That said, it seems the imports should be updated to: "cloud.google.com/go" from the newer(?) repo here: google-cloud-go

from inletsctl.

@burtonr I saw that repo initially, but the new repo only had compute/metadata sub module. I may be wrong here though

from inletsctl.

Ah yes, I see that now. At a quick glance, it looks more complete, and official. Sadly, you are correct.

I also found this closed issue asking the same question: googleapis/google-cloud-go#1605

Basically saying: No, there is no official library for interacting with GCP Compute Engine...

In other words, it's quite possible the server side has changed, but the client library is behind 🤷‍♂

from inletsctl.

@alexellis , this can be closed as a dup of #39

from inletsctl.

/close

from inletsctl.

Why don't we set up Derek access for contributors to this repo? Can you help Adam?

from inletsctl.

@alexellis, sure. I can help.

from inletsctl.