recent commit broke Nim CI about inim HOT 12 CLOSED

I'm scared to be the maintainer of an "important package" - time to get serious!

I'll set up strong CI. Cheers!

from inim.

You're on the ball! Thank you for reporting this.

But... it works for me:

 λ~ nimble update
Downloading Official package list
    Success Package list downloaded.

 λ  ~ nimble install inim
Downloading https://github.com/inim-repl/INim using git
  Verifying dependencies for [email protected]
      Info: Dependency on cligen@>= 0.9.15 already satisfied
  Verifying dependencies for [email protected]
      Info: Dependency on noise@any version already satisfied
  Verifying dependencies for [email protected]
 Installing [email protected]
   Building inim/inim using c backend
    Prompt: [email protected] already exists. Overwrite? [y/N]
    Answer: y
   Success: inim installed successfully.

I don't recognize what you're doing, as I'm new to Nim - how can I help?

from inim.

OH! the INim tests. right! I'm a professional 😆

Fixing now. Great idea to get some CI, maybe a simple github action 👌

from inim.

do you know a good way of setting up CI for Nim? (before I do an obvious CI)

from inim.

setting up proper CI could take some time, but if you have a simple fix in the meantime (to un-break nim CI) that would be appreciated! (news a new release tag too)

just make sure nimble test passes locally

as for a good way, i recommend azure pipelines (10 free parallel builds); pick your favorite starting point:
https://github.com/search?q=filename%3Aazure-pipelines.yml+nim

from inim.

@timotheecour I've commented the offending test, pending a fix. Tests now pass.

What caught this error? Do you run a pipeline for every nimble package?

from inim.

Fixed in v0.4.5

from inim.

What caught this error? Do you run a pipeline for every nimble package?

Nim/testament/important_packages.nim, run by nim's CI for each PR

Fixed in v0.4.5

confirm it works, thanks for the quick fix!
ya definitely a CI is needed;

simplest i could find is https://github.com/loloicci/nimly/blob/429db84b4a4fed9ee6caaeb636634b20c66307c3/azure-pipelines.yml ; maybe try that?

from inim.

@timotheecour do you have time to help me understand the OSError in my new CI? https://github.com/inim-repl/INim/runs/585421353

from inim.

I think I figured it out! nim-noise's tests run with -d:prompt_no_history, so as to not create temp files. I'll try that in our tests.

from inim.

👌

from inim.

@timotheecour do you have time to help me understand

sorry, I just saw ur msg (US/CA time zone...)

I think I figured it out

great! now that you've set up CI, I could also recommend merging through PR's instead of directly pushing to master; that's a good practice (eg you can see CI running and squash+merge each PR once CI is green; also better to get feedback etc)

from inim.