Allow specifying interceptors on chains about kee-frame HOT 6 CLOSED

In general I would like the API of kee-frame to be as simple as possible, preferring generic lower level constructs over specific higher level ones. That will make it easier to maintain a stable API in the long term, and makes everything more composable.

In this case, that would mean allowing interceptors per event, the same way re-frame does. It would be convenient to specify global interceptors for a chain, but it comes with the penalty of cluttering the API. It would need to be very valuable to justify it, given that it only reduces code size, not complexity.

from kee-frame.

Thanks for reporting!

I will look into this. for the -named chains, the API starts to get messy. I would like to support this, but at the same time not make the core API to complicated for the 90% of users that only need the simple cases. Please feel free to drop in some usage examples, with suggested API, so we can discuss!

from kee-frame.

The two options I can think of are to use the same interceptor for all, or interpose an interceptor for each one.

e.g. 1

(reg-chain
  :load/foo
  [auth/logged-in? (path [:path :to :foo])]
  (fn [ctx ev]
    ;; step 1
    ...)
  (fn [ctx ev]
    ;; Step 2
    ...))

(reg-chain-named
  :load/foo
  [auth/logged-in? (path [:path :to :foo])]
  (fn [ctx ev]
    ;; step 1
    ...)
  :foo/set
  (fn [ctx ev]
    ;; Step 2
    ...))

e.g. 2

(reg-chain
  :load/foo
  [auth/logged-in?]
  (fn [ctx ev]
    ;; step 1
    ...)
  [auth/audit-success (path [:path :to :foo])]  
  (fn [ctx ev]
    ;; Step 2
    ...))

(reg-chain-named
  :load/foo
  [auth/logged-in?]
  (fn [ctx ev]
    ;; step 1
    ...)
  :foo/set
  [auth/audit-success (path [:path :to :foo])]  
  (fn [ctx ev]
    ;; Step 2
    ...))

from kee-frame.

Well put. I agree.

from kee-frame.

Is this something you would consider doing as a pull request? I'm thinking about it,, but could take some time as I'm quite busy these days.

from kee-frame.

I actually think I solved it. Will write some more tests, and call it a day.

from kee-frame.