Git Product home page Git Product logo

Comments (5)

Ultimater avatar Ultimater commented on August 17, 2024 1

@georanma The response I got was merely the author of the issue claiming it's abandoned. We can be our own judge if a package is abandoned or not. Haven't heard back from Lars Strojny yet that the package is abandoned.

Lars' last comment was 4 months ago:

Haven’t looked at all into support PHP 8.0 yet, so no idea. Can’t imagine it to be terribly hard to achieve so if anybody wants to get a PR rolling, help is very welcome!

The first step would be to run the test suite under PHP 8, that should tell us quite well what is breaking and what works.

He might just need time and/or a reminder to merge the PR and make a release.

Alternatively, we can work on migrating over to a different XMLRPC package.

The older infusionsoft sdk, before OAuth2, made use of the this package:
https://github.com/gggeek/phpxmlrpc
It has a PHP 8 update. Although I suspect it's losing momentum.

Maybe try out Zend Framework's xmlrpc, which is now Laminas:
https://docs.laminas.dev/laminas-xmlrpc/client/

from infusionsoft-php.

Ultimater avatar Ultimater commented on August 17, 2024 1

@georanma The test coverage is very basic. Need to run some tests by hand when doing these kinds of changes.

If you want to tackle it, go for it.

from infusionsoft-php.

georanma avatar georanma commented on August 17, 2024

@Ultimater I've been waiting on a response in that repo to try the upgrade myself, but I guess we have the answer now.

from infusionsoft-php.

georanma avatar georanma commented on August 17, 2024

@Ultimater ya, I pulled their package, and started to do the update, but their own internal code sniffs package was a blocker. I didnt feel comfortable working against that.

The Laminas package is probably the way to go, and that it wouldnt take a lot to swap it out. Do you know if the test coverage is good enough on our package, or do we need to do some tests by hand?

from infusionsoft-php.

Ultimater avatar Ultimater commented on August 17, 2024

lstrojny/fxmlrpc#80 has put out a release version 0.20.0 which adds PHP 8 support.

from infusionsoft-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.