Comments (5)
Unfortunately I don't see easy to implement (and maintain) alternative.
I don't like to patch (more, undoable patch!) many tab-related functions (and extensions may use own functions).
Or I may check call stack in handler for "TabOpen" event. But some tab-related extension may change functions, and call stack will be changed too.
And useful trick with current behavior: you can make current tab private to open link from external application in private tab. :)
from private_tab.
About inheritance. What to do for something like onclick="window.open('...')" on pages? It's easy to disable inheritance, but some links may be opened in new tabs without user request.
from private_tab.
Private_Tab gives the user the ability to choose to open a tab in a private session, but it is in the context of the link they are trying to open. If the user wants the "next" tab to ALSO open in a private session, then they would click "open link in new private tab" again.
In the case of onclick="window.open(...)" or target="_blank", I do not have a good answer. Maybe the user should still have to click "open link in new private tab" again?
I understand the reasoning for your current implementation. I may be trying to shoehorn your API into my use-case, and it just doesn't match up as well as I had hoped it would.
from private_tab.
@kainsavage I can see the benefit to both sides but, as an end user, I never bother with the context menu and just use middle-click to open new tabs. I expect middle-clicking and window.open
to preserve the privacy state of the parent tab unless I explicitly change it. In fact, I care about this much more than issue #40.
Among other reasons:
- it ensures that no site can see both my non-private cookies and a HistoryBlock'd URL via the Referer header. Either the site is private or I manually copied the URL into a fresh tab.
- If
window.open
doesn't preserve privacy state, you could end up with a child window/tab breaking for lack of access to the parent's session cookie.
I'd be perfectly fine with HistoryBlock turning on Private Browsing for tabs but not turning it off again. It means that I don't forget to turn it on but, if I forget to turn it off, whatever site I visit next is isolated from my "Remember Me" cookies.
Basically, I see it as a way to maximize the chance of mistakes exhibiting failsafe behaviour.
from private_tab.
As a User I'm very much happy with the current behavior of subsequent tabs ( on middle click ) also being private Tabs because if we do a google search in a private tab we definitely want to open the individual results also in private mode with middle click [ rather than right click open as new private tab ] .
@ssokolow as he mentioned it will also maximize the chance of failsafe behaviour .
@Infocatcher I think many users use like me . So please don't change this behaviour
from private_tab.
Related Issues (20)
- "private:" bookmarks not always working when tab is already private
- Firefox saves information about websites visited in a private tab to disk
- about:performance reports performance issues HOT 1
- Open private tab from history HOT 2
- [Request] blacklist domains and blacklist patterns (Always Open in a Private Tab/Window)
- Breaks Firefox if you try to open Responsive Design Mode HOT 1
- windows close button not working while this add-on is enabled since firefox 55 HOT 1
- No private indicator in new tab when middle mouse from normal tab HOT 1
- Saving private tabs in sessions (question) HOT 3
- Compatibility issue on latest Firefox Dev Edition HOT 3
- Malfunction when I type a romanian caracter in romanian language
- Please upgrade this addon to Firefox 57. HOT 2
- Maintaining this Add-on at the Pale Moon Add-ons Site HOT 6
- WebExtension someday? HOT 4
- Not working with Firefox Quantum (official release 57) HOT 5
- Not compatible with Firefox Quantum HOT 1
- update for Firefox 57, please! HOT 1
- So... Is the update for Quantum ever going to happen? HOT 2
- Newly created private tab stuck
- Would it be possible to port this extension to Waterfox 68, seeing how it still supports legacy add-ons? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from private_tab.