Comments (7)
Unfortunately system colors aren't good too: only gray variants on Windows and may be not compatible with non-default themes.
from private_tab.
With 17afdcf commit for bright default text will be used following style:
#privateTab-tooltip-isPrivateTabLabel {
color: currentColor;
text-decoration: underline;
-moz-text-decoration-color: currentColor;
-moz-text-decoration-style: dashed;
}
Test version: private_tab-0.1.1pre15-fx-sm.xpi
from private_tab.
My mistake. I didn't mean to specifically say that system colours should always be used. What I meant but didn't communicate properly was that, if the theme decides to use system-provided colors, the tooltips should follow along to avoid this kind of breakage.
The test version is perfectly readable though the "(private tab)" label isn't as eye-grabbing with only a dashed underline.
(Hence why I suggested using bold to replace the blue colour. It'd look good and be simpler than the alternative: Using colour theory to generate candidate foreground colors that complement the background color, calculating the luminosity contrast ratio of each, and then picking one with a ratio of at least 5:1.)
from private_tab.
I'm not sure about bold text... Some theme may use it. And bold text appearance is font-dependent.
Also I think, that underline is mere specific and more likely will not be used in themes.
About alternative. I really won't use complex things for simple features. Here may be background images or background gradients...
So, I think, this fix is good approach. :)
And may be easily corrected using userChrome.css – not so easily as using some options, but better than nothing.
Really here is another issue: missing options for private tabs appearance. But many users asks about "something instead of underline". And this is problem with themes compatibility. Only underline and changed icons from example styles looks good in most themes. But I prefer original icons.
from private_tab.
So, can I close this issue? :)
from private_tab.
Yeah. My only concern with the underline is that it might not be as eye-grabbing as intended. If you're OK with that, then the test version is perfect.
from private_tab.
OK, I tested, and bold + underline looks not so bad. :)
from private_tab.
Related Issues (20)
- "private:" bookmarks not always working when tab is already private
- Firefox saves information about websites visited in a private tab to disk
- about:performance reports performance issues HOT 1
- Open private tab from history HOT 2
- [Request] blacklist domains and blacklist patterns (Always Open in a Private Tab/Window)
- Breaks Firefox if you try to open Responsive Design Mode HOT 1
- windows close button not working while this add-on is enabled since firefox 55 HOT 1
- No private indicator in new tab when middle mouse from normal tab HOT 1
- Saving private tabs in sessions (question) HOT 3
- Compatibility issue on latest Firefox Dev Edition HOT 3
- Malfunction when I type a romanian caracter in romanian language
- Please upgrade this addon to Firefox 57. HOT 2
- Maintaining this Add-on at the Pale Moon Add-ons Site HOT 6
- WebExtension someday? HOT 4
- Not working with Firefox Quantum (official release 57) HOT 5
- Not compatible with Firefox Quantum HOT 1
- update for Firefox 57, please! HOT 1
- So... Is the update for Quantum ever going to happen? HOT 2
- Newly created private tab stuck
- Would it be possible to port this extension to Waterfox 68, seeing how it still supports legacy add-ons? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from private_tab.