Comments (5)
Known issue: SeaMonkey doesn't dispatch "SSWindowClosing" event, so we use "close" or "beforeunload". As a result private tabs will be removed anyway, if browser will ask confirmation to close multiple tabs.
from private_tab.
Seems all works now, closed.
Second known issue: Session Manager still saves private tabs in sessions.
Should be fixed from Session Manager side, I think.
from private_tab.
Should be fixed from Session Manager side, I think.
=> http://forums.mozillazine.org/viewtopic.php?p=12807329#p12807329
from private_tab.
I'll mention that your current fix results in corrupted session data in sessionstore.js if the current selected tab in the window is the private tab or after it. There is a "windows[i].tab[i].selected" field that should match the index of the selected tab (starting with 1). When your code strips out the private tab it doesn't update the index.
So for example if there are two tabs in the window: a normal and private, and the private one is selected, the "selected" value will be 2, even though there will only be one tab stored in the session for that window.
This does seem to get cleaned up when the browser is exited, but on a crash it is not. SessionStore has some smarts to prevent selecting a tab that doesn't exists, but it could still result in the wrong tab being selected after a crash.
from private_tab.
but it could still result in the wrong tab being selected after a crash
Oh, I forgot about this case. Thanks, corrected: 332ddcb
from private_tab.
Related Issues (20)
- "private:" bookmarks not always working when tab is already private
- Firefox saves information about websites visited in a private tab to disk
- about:performance reports performance issues HOT 1
- Open private tab from history HOT 2
- [Request] blacklist domains and blacklist patterns (Always Open in a Private Tab/Window)
- Breaks Firefox if you try to open Responsive Design Mode HOT 1
- windows close button not working while this add-on is enabled since firefox 55 HOT 1
- No private indicator in new tab when middle mouse from normal tab HOT 1
- Saving private tabs in sessions (question) HOT 3
- Compatibility issue on latest Firefox Dev Edition HOT 3
- Malfunction when I type a romanian caracter in romanian language
- Please upgrade this addon to Firefox 57. HOT 2
- Maintaining this Add-on at the Pale Moon Add-ons Site HOT 6
- WebExtension someday? HOT 4
- Not working with Firefox Quantum (official release 57) HOT 5
- Not compatible with Firefox Quantum HOT 1
- update for Firefox 57, please! HOT 1
- So... Is the update for Quantum ever going to happen? HOT 2
- Newly created private tab stuck
- Would it be possible to port this extension to Waterfox 68, seeing how it still supports legacy add-ons? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from private_tab.