Comments (6)
Hey @peterlazar1993
So, the repo doesn't clone the base, but uses the files inside base to patch up a fresh RN install. We utilize rnpm to do the patching for specific dependencies.
So if I understand what you're saying, when a brand new RN project comes down, and rnpm is run, it doesn't add the necessary code to MainActivity.java.
@markrickert - you helped us get this installed, can you weigh in?
Plans for moving forward:
option1 - Remove push notifications from ignite
option2 - Add an extra part of the script that copies in that line (and any other extraneous lines) that packages may miss.
Personally, we need option2, so we're going to need a "Find this line of code, and then insert here" function written. I'm happy to add this should we go with option 2. @fvonhoven - and @kevinvangelder this is something we can pair on to get you guys dealing with the generator.
from ignite.
Hello,
I encountered the same kind of issues about two weeks ago with android.
If it can help, this was the final MainActivity.java
package com.xxx;
import com.facebook.react.ReactActivity;
import com.oblador.vectoricons.VectorIconsPackage;
import com.dieam.reactnativepushnotification.ReactNativePushNotificationPackage;
import com.i18n.reactnativei18n.ReactNativeI18n;
import com.facebook.react.ReactPackage;
import com.facebook.react.shell.MainReactPackage;
import android.content.Intent; // <--- Import Intent
import java.util.Arrays;
import java.util.List;
public class MainActivity extends ReactActivity {
private ReactNativePushNotificationPackage mReactNativePushNotificationPackage; // <------ Add Package Variable
/**
* Returns the name of the main component registered from JavaScript.
* This is used to schedule rendering of the component.
*/
@Override
protected String getMainComponentName() {
return "xxx";
}
/**
* Returns whether dev mode should be enabled.
* This enables e.g. the dev menu.
*/
@Override
protected boolean getUseDeveloperSupport() {
return BuildConfig.DEBUG;
}
/**
* A list of packages used by the app. If the app uses additional views
* or modules besides the default ones, add more packages here.
*/
@Override
protected List<ReactPackage> getPackages() {
mReactNativePushNotificationPackage = new ReactNativePushNotificationPackage(this); // <------ Initialize the Package
return Arrays.<ReactPackage>asList(
new MainReactPackage(),
new VectorIconsPackage(),
new ReactNativeI18n(),
mReactNativePushNotificationPackage
);
}
@Override
protected void onNewIntent (Intent intent) {
super.onNewIntent(intent);
mReactNativePushNotificationPackage.newIntent(intent);
}
}
from ignite.
I'm going to have a discussion with the good people who made rnpm
tomorrow. If I can fix the above, I will. If not, we're going to remove push notifications from the default ignite project.
from ignite.
https://github.com/rnpm/rnpm/blob/master/src/config/android/index.js#L107
zo0r/react-native-push-notification#75
from ignite.
Just pointed master at my branch, this works now. Might take a moment to also add the permissions.
from ignite.
https://github.com/infinitered/ignite/releases/tag/0.2.4
from ignite.
Related Issues (20)
- Creating bare react native project without expo HOT 5
- Unable to access Store A values/actions in Store B firectly using useStores hook HOT 8
- Update boilerplate/README.md HOT 1
- Add Social Preview to GitHub Settings
- Generic function load in storage [boilerplate] HOT 1
- Add responsive sizing to custom <Text /> component HOT 1
- Lack of documentation for a quick start. HOT 1
- Typescript broken with mobx state tree HOT 5
- `Error: Cannot find module 'metro-cache'` when initiating the new ignite project HOT 7
- Docs: Add screenshots of each component in docs HOT 2
- [request]: Support RN v0.74 HOT 2
- [boilerplate] Add default privacy manifest
- Create project with bare react-native have expo commands HOT 7
- DevMenu is null in NativeModules HOT 4
- A Better type for styles HOT 4
- Fresh install errors with `sh: patch-package: command not found`
- New ignite project HOT 2
- android build error with Execution failed for task ':react-native-reanimated:configureCMakeDebug[arm64-v8a]' HOT 3
- Running App Resulting in Blank (White) Screen HOT 3
- Getting Started - the app lands on a blank page HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ignite.