Uncaught TypeError when using this plugin about webpack-common-shake HOT 5 OPEN

I have same issue, and figured out that webpack-common-shake is doing some transformation on reserved words.
The part of SockJS contains following code:

, number: function(max) {
    return Math.floor(Math.random() * max);
  }

, numberString: function(max) {
    var t = ('' + (max - 1)).length;
    var p = new Array(t + 1).join('0');
    return (p + this.number(max)).slice(-t);
  }

After the common-shake plugin above code is transformed as:

, "number": ((function(max) {
    return Math.floor(Math.random() * max);
  }),null)

which this.number ended up being null, instead of function.

from webpack-common-shake.

👍 That's exactly the same problem I have. It seems that the comma operator shouldn't be here.

from webpack-common-shake.

Hello!

I'll take a look at it later this week. It has nothing to do with reserved words, however, as number is not one of them.

The way it adds comma and null is a normal mode of operation. This function is unused in this library, so it isolates it for later removal by UglifyJS.

Will see what's the underlying problem a bit later.

Thanks for reporting!

from webpack-common-shake.

Hello @indutny thanks for all the work you have done so far! It definitely helped me a lot!

But starting from today, i started to encounter this issue as well. Do you have any updates regarding this problem?

from webpack-common-shake.

Having same issue when trying to use createVerify reexported from browserify-sign by browserify-crypto

from webpack-common-shake.